From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B79C76192 for ; Tue, 16 Jul 2019 07:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47A4421738 for ; Tue, 16 Jul 2019 07:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563261035; bh=pL4HI7tq45JjHGebbC89eueuXA5IWsPnnCyLKxWS3Ag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hUJdNVBn4zs+oq1riH1lpKtUen1TOG9Mqo2Xh2tnwcRQKkHkIDdr9n13TCTFpixXo 1Ja2PYDYIcd6QysC4VclPT/WsUBE1aTjmuOX4b8twwRm4OzhTb/J/836c4YhDcXi4C M2jEXmosdssyS9fjETwCMvGn+E3E7vaDquQqhuqs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbfGPHKe (ORCPT ); Tue, 16 Jul 2019 03:10:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:33726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726420AbfGPHKe (ORCPT ); Tue, 16 Jul 2019 03:10:34 -0400 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E9E0C20880; Tue, 16 Jul 2019 07:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563261033; bh=pL4HI7tq45JjHGebbC89eueuXA5IWsPnnCyLKxWS3Ag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X88DsIla1HEWYEtdE+IcCsLmmrqu/MohvCg/ZRxbTiqxE1zej8g7hfk0Beb+f6yXb r4B1y6wWWYDTPayR9G4XX555oVIOzl0nX6Cg1xORDgmrh59YEThx/taWRMALokE3Ux SZPChhDgyqIy8h3fx1DG53pE8PhyXSXIoitiqUx8= Date: Tue, 16 Jul 2019 10:10:30 +0300 From: Leon Romanovsky To: Selvin Xavier Cc: linux-rdma@vger.kernel.org, dledford@redhat.com, jgg@ziepe.ca, linux-nvme@lists.infradead.org, stable@vger.kernel.org, Parav Pandit Subject: Re: [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison Message-ID: <20190716071030.GH10130@mtr-leonro.mtl.com> References: <20190715091913.15726-1-selvin.xavier@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190715091913.15726-1-selvin.xavier@broadcom.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jul 15, 2019 at 05:19:13AM -0400, Selvin Xavier wrote: > GID entry consist of GID, vlan, netdev and smac. > Extend GID duplicate check companions to consider vlan_id as well > to support IPv6 VLAN based link local addresses. Introduce > a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information. > > The issue is discussed in the following thread > https://www.spinics.net/lists/linux-rdma/msg81594.html > > Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs") > Cc: # v5.2+ > Reported-by: Yi Zhang > Co-developed-by: Parav Pandit > Signed-off-by: Parav Pandit I never understood why bad habits are so stinky. Can you please explain us what does it mean Co-developed-by and Signed-off-by of the same person in the same patch? > Signed-off-by: Selvin Xavier > --- Thanks