Re: [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison

Leon Romanovsky
2019-07-16T07:10:35Z

On Mon, Jul 15, 2019 at 05:19:13AM -0400, Selvin Xavier wrote:
> GID entry consist of GID, vlan, netdev and smac.
> Extend GID duplicate check companions to consider vlan_id as well
> to support IPv6 VLAN based link local addresses. Introduce
> a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information.
>
> The issue is discussed in the following thread
> https://www.spinics.net/lists/linux-rdma/msg81594.html
>
> Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs")
> Cc: <stable@vger.kernel.org> # v5.2+
> Reported-by: Yi Zhang <yi.zhang@redhat.com>

> Co-developed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Parav Pandit <parav@mellanox.com>

I never understood why bad habits are so stinky.

Can you please explain us what does it mean Co-developed-by and
Signed-off-by of the same person in the same patch?

> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---

Thanks