From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B299EC76190 for ; Mon, 22 Jul 2019 18:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A7002190D for ; Mon, 22 Jul 2019 18:07:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ecr7HpkJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727367AbfGVSHt (ORCPT ); Mon, 22 Jul 2019 14:07:49 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:34449 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbfGVSHt (ORCPT ); Mon, 22 Jul 2019 14:07:49 -0400 Received: by mail-vs1-f66.google.com with SMTP id m23so26869843vso.1 for ; Mon, 22 Jul 2019 11:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cmW+iIJBcAPXYuBJ0X70RuJw3nKWx6Ck24ISTbz4CEs=; b=ecr7HpkJ/GPjpuVFLx7tTl5nq1d1iUDbKwdlnIYeT6V8ma1d+wg9/MJjuQwtyKqzih QeHMj6zOIBFJhbLoTvcDZGPbJSferveTR0mu/KI/setje9er6O5qXDyom3wHCufV7/Pi 3UQymcesV8YMc+MJ0dOZcKfviFC5gRKW1JnakN5ef7VDFeCkicby89KgbFRCg0yaM4C/ o1j3+ySz3Lkbzfti+4RHITgEG9bqsPDppPOfcTvMhnuz7JyPwElNZSI371i7FV0IYolf mofl8nmvAiy33e4bbe8MvQ3PZsA+U642zpBMIy3r5E++TuInZ8ltgdP0Mgt+Rbzndl5u Ff1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cmW+iIJBcAPXYuBJ0X70RuJw3nKWx6Ck24ISTbz4CEs=; b=ZP0brv582nbpqao9u0NxXbs3D0mwKZUjgSqyfM0iA41HEbsBxbsZU2KJft37bPG+7Y Vz/WRSMn+6rm/hwob4bxceeCeW/p7cdhLKHpDJcoXwJHb7LjH37mHfghybO59AVV9LNV 9CEq3UyKBIE2/Vd3yY1hRz81oelSfa608OtVKwXeP3M6kspRAT3xPM/TbqAgDWERmZZj ZXjY/guEkVeosONwGfgqulNpwO6VqZEAAqYudgKvzFr3trKqASc55cExHKI7bTZxBPS+ b/7XSNi/b/sw9gPy6dxiYe4gQJ5eX6XyhXtiw268mrvWp4+21CMcSI7WAB0QmNMguSY8 tuwQ== X-Gm-Message-State: APjAAAXQqeAbB1ScMzf9PNMzqCexl7UcKfsVYISjIQ7BhCth6K2rtrez SWi0ltyvXEPhKvXxbzaMJnaEZw== X-Google-Smtp-Source: APXvYqx5Od80W34I1fDAgrOP6mzw1I8zF4ZN9uUihErCnhuyEo+zpkg3qx27zyPVZSVitQtTLpxDGg== X-Received: by 2002:a67:eb93:: with SMTP id e19mr44004699vso.208.1563818868687; Mon, 22 Jul 2019 11:07:48 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id u8sm15170119vke.34.2019.07.22.11.07.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 11:07:48 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hpciw-0002TP-Hf; Mon, 22 Jul 2019 15:07:46 -0300 Date: Mon, 22 Jul 2019 15:07:46 -0300 From: Jason Gunthorpe To: Selvin Xavier Cc: linux-rdma@vger.kernel.org, dledford@redhat.com, linux-nvme@lists.infradead.org, stable@vger.kernel.org, Parav Pandit Subject: Re: [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison Message-ID: <20190722180746.GA9441@ziepe.ca> References: <20190715091913.15726-1-selvin.xavier@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190715091913.15726-1-selvin.xavier@broadcom.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jul 15, 2019 at 05:19:13AM -0400, Selvin Xavier wrote: > GID entry consist of GID, vlan, netdev and smac. > Extend GID duplicate check companions to consider vlan_id as well > to support IPv6 VLAN based link local addresses. Introduce > a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information. > > The issue is discussed in the following thread > https://www.spinics.net/lists/linux-rdma/msg81594.html > > Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs") > Cc: # v5.2+ > Reported-by: Yi Zhang > Co-developed-by: Parav Pandit > Signed-off-by: Parav Pandit > Signed-off-by: Selvin Xavier > Tested-by: Yi Zhang > Reviewed-By: Leon R... > Tested-by: Leon R... > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 7 +++++-- > drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++++++++---- > drivers/infiniband/hw/bnxt_re/qplib_res.h | 2 +- > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 14 +++++++++----- > drivers/infiniband/hw/bnxt_re/qplib_sp.h | 7 ++++++- > 5 files changed, 30 insertions(+), 13 deletions(-) Applied to for-rc, thanks Please also fix that sketchy use of the gid_index Jason