From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1E4C7618B for ; Tue, 23 Jul 2019 07:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B33122511 for ; Tue, 23 Jul 2019 07:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563867824; bh=BgmHsAmIshLYPkLDnZFVhS1Nx/JPKepABG/ECHbDKPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=h5I7uc6+JL/ZjFLRfdkKF0LBjRwLMOVb7P3W88HVN+XP2uZbDJXIhRQTtFDVyNEz5 8Elsst483Qo+OqXORgtGmyCfFUPX4TwulhO7lAbbO0gZ+oajyvlGKW/oxdaQVkfyYL hjMdnpw0lxzVkN2Zj44Mh1MZtJW7scKsfKIif5DY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388377AbfGWHnn (ORCPT ); Tue, 23 Jul 2019 03:43:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:58266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732983AbfGWHnn (ORCPT ); Tue, 23 Jul 2019 03:43:43 -0400 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21C66218BE; Tue, 23 Jul 2019 07:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563867822; bh=BgmHsAmIshLYPkLDnZFVhS1Nx/JPKepABG/ECHbDKPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BSXRU+Q8/DdmUo7uC6DHEPWCD5tsmh9WXb/RdFZHJdJK1IZM5kS0+bhCA1IFcm/rt rR1kAUPiolpPpBESUhvwILSD9bLh1sSf/F1d4I0VlTNlwgVOgHJ12zhv62iN/uw2M7 x9FPclzifpBxKF1168zr8Z0ZsfWmSN6tXlHuWJdY= Date: Tue, 23 Jul 2019 10:43:39 +0300 From: Leon Romanovsky To: YueHaibing Cc: oulijun@huawei.com, xavier.huwei@huawei.com, dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH] RDMA/hns: Fix build error for hip08 Message-ID: <20190723074339.GJ5125@mtr-leonro.mtl.com> References: <20190723024908.11876-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723024908.11876-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jul 23, 2019 at 10:49:08AM +0800, YueHaibing wrote: > If INFINIBAND_HNS_HIP08 is selected and HNS3 is m, > but INFINIBAND_HNS is y, building fails: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit': > hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client' > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init': > hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client' It means that you have a problem with header files of your hns3. > > Reported-by: Hulk Robot > Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE") > Signed-off-by: YueHaibing > --- > drivers/infiniband/hw/hns/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig > index b59da5d..4371c80 100644 > --- a/drivers/infiniband/hw/hns/Kconfig > +++ b/drivers/infiniband/hw/hns/Kconfig > @@ -23,7 +23,8 @@ config INFINIBAND_HNS_HIP06 > > config INFINIBAND_HNS_HIP08 > bool "Hisilicon Hip08 Family RoCE support" > - depends on INFINIBAND_HNS && PCI && HNS3 > + depends on INFINIBAND_HNS && (INFINIBAND_HNS = HNS3) This is wrong. > + depends on PCI > ---help--- > RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip08 SoC. > The RoCE engine is a PCI device. > -- > 2.7.4 > >