From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFB2C7618B for ; Tue, 23 Jul 2019 13:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FACA218D4 for ; Tue, 23 Jul 2019 13:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XQ/RLMil" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbfGWNhl (ORCPT ); Tue, 23 Jul 2019 09:37:41 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:43778 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbfGWNhk (ORCPT ); Tue, 23 Jul 2019 09:37:40 -0400 Received: by mail-qk1-f194.google.com with SMTP id m14so5427231qka.10 for ; Tue, 23 Jul 2019 06:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BV3g3NzuGp2I4JOWUlVwtiumFmjFWG11w8FIYIpu7kQ=; b=XQ/RLMilf7JYd4QxsVFlm1Ezv5tYekt7L1E3NSjRuh73+LefrAqfkxCSlHWTCzBxQr ZK4jpZm/tG1KVE/vGwqc4Bq6i0wbiw8El27ucO2yorJ99AJJa/d2Jc6JAwEBaeSSctja DXe+gTJpsmQQUcRwQl8LKq/5UDoUrOujvijKs4C6q3V5vMn0pY6mKDTIaVb/ekez0At1 VV2zgzxkL0vdZ73159UZHpxZGLxCZYknqaM7qoN68xXRbGnWjcAUbcGkKklL8mLDW3lI TtwQm+3k/G8M3XuDPHWJuNZXrzKRMaDK67V+vkMi9eoxQ/3ic9FxLdc/lLw/cvYHosiA kAqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BV3g3NzuGp2I4JOWUlVwtiumFmjFWG11w8FIYIpu7kQ=; b=nznLm02xfKSxqqCWa084Xd4ROyTEfzBn35WgFgFWdXg8JiWGVC5wmjQJcCsSJDjJTJ zh8l0+eWIMxts1B+API2MHzSrPATIZRQd5dXkJvmiyVkjiUAm0AAlOYa0KB/E1QfcMPu 12aM8AoD0MVVan9pJK52OJ62iPGu83DTUS27+75XrOgpuayklVEcQzCDSaX3g7+PWSg1 jazl1enp1gqO7YwWME25yWyQq29GYpKmAgdFT+CiFWQ92JXxkyefLgW42QoGAVkRl3ZB i3+N4X2KM2bAVBQKENEmYZMcTbPc/SNNoC3BoTsuSTbXIjEZXL4g/4OjjbfDd+HpLjv6 39nQ== X-Gm-Message-State: APjAAAWwIqSqwa2KCrmopf5FKkkabql4a8H8Z51gA44D6Vqw4elaQfYe Q0ua4WDCtOtwlMBDgjSF0vst0g== X-Google-Smtp-Source: APXvYqxPn04Nx/qm9eIGQ3LU0Fs5EwZ5fHRzCtY6vm1ksvXraqBBP8PCqJz6BC47gMTXLs3RkMaivw== X-Received: by 2002:ae9:dfc3:: with SMTP id t186mr47784983qkf.461.1563889060140; Tue, 23 Jul 2019 06:37:40 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id x2sm19297155qkc.92.2019.07.23.06.37.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jul 2019 06:37:39 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hpuz5-0005fS-2e; Tue, 23 Jul 2019 10:37:39 -0300 Date: Tue, 23 Jul 2019 10:37:39 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: YueHaibing , oulijun@huawei.com, xavier.huwei@huawei.com, dledford@redhat.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH] RDMA/hns: Fix build error for hip08 Message-ID: <20190723133739.GC15357@ziepe.ca> References: <20190723024908.11876-1-yuehaibing@huawei.com> <20190723074339.GJ5125@mtr-leonro.mtl.com> <20190723123402.GA15357@ziepe.ca> <20190723133540.GM5125@mtr-leonro.mtl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723133540.GM5125@mtr-leonro.mtl.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jul 23, 2019 at 04:35:40PM +0300, Leon Romanovsky wrote: > On Tue, Jul 23, 2019 at 09:34:02AM -0300, Jason Gunthorpe wrote: > > On Tue, Jul 23, 2019 at 10:43:39AM +0300, Leon Romanovsky wrote: > > > On Tue, Jul 23, 2019 at 10:49:08AM +0800, YueHaibing wrote: > > > > If INFINIBAND_HNS_HIP08 is selected and HNS3 is m, > > > > but INFINIBAND_HNS is y, building fails: > > > > > > > > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit': > > > > hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client' > > > > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init': > > > > hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client' > > > > > > It means that you have a problem with header files of your hns3. > > > > > > > > > > > Reported-by: Hulk Robot > > > > Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE") > > > > Signed-off-by: YueHaibing > > > > drivers/infiniband/hw/hns/Kconfig | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig > > > > index b59da5d..4371c80 100644 > > > > +++ b/drivers/infiniband/hw/hns/Kconfig > > > > @@ -23,7 +23,8 @@ config INFINIBAND_HNS_HIP06 > > > > > > > > config INFINIBAND_HNS_HIP08 > > > > bool "Hisilicon Hip08 Family RoCE support" > > > > - depends on INFINIBAND_HNS && PCI && HNS3 > > > > + depends on INFINIBAND_HNS && (INFINIBAND_HNS = HNS3) > > > > > > This is wrong. > > > > It is tricky. It is asserting that the IB side is built as a module if > > the ethernet side is a module.. > > > > It is kind of a weird pattern as the module config is INFINIBAND_HNS > > and these others are just bool opens what to include, but I think it > > is OK.. > > select ??? select doesn't influence module or not any different from depeends Jason