From: Jason Gunthorpe <jgg@ziepe.ca>
To: Honggang Li <honli@redhat.com>
Cc: bvanassche@acm.org, linux-rdma@vger.kernel.org
Subject: Re: [rdma-core patch v3] srp_daemon: improve the debug message for is_enabled_by_rules_file
Date: Thu, 25 Jul 2019 13:53:16 -0300 [thread overview]
Message-ID: <20190725165316.GA27749@ziepe.ca> (raw)
In-Reply-To: <20190715041614.27979-1-honli@redhat.com>
On Mon, Jul 15, 2019 at 12:16:14AM -0400, Honggang Li wrote:
> If the target was disallowed by rule file, user can not distinguish that
> from the old debug message.
>
> pr_debug("Found an SRP target with id_ext %s - check if it allowed by rules file\n", target->id_ext);
>
> It implicitly implied by the message next to the old debug message.
>
> pr_debug("Found an SRP target with id_ext %s - check if it is already connected\n", target->id_ext);
>
> The improved debug message will feedback the check result of rule file, user
> no longer needs to wonder the target is allowed or not.
>
> Signed-off-by: Honggang Li <honli@redhat.com>
> srp_daemon/srp_daemon.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2019-07-25 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 4:16 [rdma-core patch v3] srp_daemon: improve the debug message for is_enabled_by_rules_file Honggang Li
2019-07-23 19:34 ` Bart Van Assche
2019-07-25 16:53 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725165316.GA27749@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=honli@redhat.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox