From: Jason Gunthorpe <jgg@ziepe.ca>
To: Michal Kalderon <michal.kalderon@marvell.com>
Cc: ariel.elior@marvell.com, dledford@redhat.com,
galpress@amazon.com, linux-rdma@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v6 rdma-next 5/6] RDMA/qedr: Add doorbell overflow recovery support
Date: Thu, 25 Jul 2019 15:01:06 -0300 [thread overview]
Message-ID: <20190725180106.GB18757@ziepe.ca> (raw)
In-Reply-To: <20190709141735.19193-6-michal.kalderon@marvell.com>
On Tue, Jul 09, 2019 at 05:17:34PM +0300, Michal Kalderon wrote:
> +static int qedr_init_user_db_rec(struct ib_udata *udata,
> + struct qedr_dev *dev, struct qedr_userq *q,
> + bool requires_db_rec)
> +{
> + struct qedr_ucontext *uctx =
> + rdma_udata_to_drv_context(udata, struct qedr_ucontext,
> + ibucontext);
> +
> + /* Aborting for non doorbell userqueue (SRQ) or non-supporting lib */
> + if (requires_db_rec == 0 || !uctx->db_rec)
> + return 0;
> +
> + /* Allocate a page for doorbell recovery, add to mmap ) */
> + q->db_rec_data = (void *)get_zeroed_page(GFP_KERNEL);
I now think this needs to be GFP_USER and our other drivers have a bug
here as well..
Jason
next prev parent reply other threads:[~2019-07-25 18:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 14:17 [PATCH v6 rdma-next 0/6] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA Michal Kalderon
2019-07-09 14:17 ` [PATCH v6 rdma-next 1/6] RDMA/core: Create mmap database and cookie helper functions Michal Kalderon
2019-07-10 12:19 ` Gal Pressman
2019-07-25 17:55 ` Jason Gunthorpe
2019-07-25 19:34 ` Michal Kalderon
2019-07-25 19:52 ` Jason Gunthorpe
2019-07-26 8:42 ` Michal Kalderon
2019-07-26 13:23 ` Jason Gunthorpe
2019-07-28 8:45 ` Gal Pressman
2019-07-29 14:06 ` Jason Gunthorpe
2019-07-28 9:30 ` Kamal Heib
2019-07-29 14:11 ` Jason Gunthorpe
2019-07-29 12:58 ` Michal Kalderon
2019-07-29 13:53 ` Gal Pressman
2019-07-29 14:04 ` Jason Gunthorpe
2019-07-29 15:26 ` [EXT] " Michal Kalderon
2019-07-29 14:07 ` Michal Kalderon
2019-07-09 14:17 ` [PATCH v6 rdma-next 2/6] RDMA/efa: Use the common mmap_xa helpers Michal Kalderon
2019-07-10 12:09 ` Gal Pressman
2019-07-09 14:17 ` [PATCH v6 rdma-next 3/6] RDMA/qedr: Use the common mmap API Michal Kalderon
2019-07-09 14:17 ` [PATCH v6 rdma-next 4/6] qed*: Change dpi_addr to be denoted with __iomem Michal Kalderon
2019-07-25 18:06 ` Jason Gunthorpe
2019-07-09 14:17 ` [PATCH v6 rdma-next 5/6] RDMA/qedr: Add doorbell overflow recovery support Michal Kalderon
2019-07-25 18:01 ` Jason Gunthorpe [this message]
2019-07-25 19:38 ` [EXT] " Michal Kalderon
2019-07-09 14:17 ` [PATCH v6 rdma-next 6/6] RDMA/qedr: Add iWARP doorbell " Michal Kalderon
2019-07-10 7:32 ` [PATCH v6 rdma-next 0/6] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA Gal Pressman
2019-07-11 7:23 ` Michal Kalderon
2019-07-25 18:01 ` Jason Gunthorpe
2019-07-25 19:40 ` [EXT] " Michal Kalderon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725180106.GB18757@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=ariel.elior@marvell.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).