Re: [PATCH for-rc] RDMA/restrack: Track driver QP types in resource tracker

[Leon Romanovsky <leon@kernel.org>]

On Tue, Jul 30, 2019 at 04:49:52PM +0300, Gal Pressman wrote:
> On 30/07/2019 16:38, Leon Romanovsky wrote:
> > On Tue, Jul 30, 2019 at 02:01:37PM +0300, Gal Pressman wrote:
> >> The check for QP type different than XRC has wrongly excluded driver QP
> >> types from the resource tracker.
> >>
> >> Fixes: 78a0cd648a80 ("RDMA/core: Add resource tracking for create and destroy QPs")
> >
> > It is a little bit over to say "wrongly". At that time, we did it on purpose
> > because it was unclear how to represent such QP types to users and we didn't
> > have vendor specific hooks introduced by Steve later on.
>
> It's very confusing to see a test running and zero QPs in "rdma res".
> I'm fine with removing the "wrongly" :), but I still think this should be
> targeted to for-rc as a bug fix.

Yes, please remove "wrongly" and change Fixes line to be
"Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")",
because before addition of EFA driver all other drivers had QPs.

>
> >
> > I would like to see the output or "rdma res" and "rdma res show qp" with
> > running driver QP after your change.
>
> gal@server [~] $ rdma res
> 0: efa_0: pd 2 cq 4 qp 2 cm_id 0 mr 2 ctx 2
> gal@server [~] $ rdma res show qp
> link efa_0/1 lqpn 0 type UNKNOWN state RTS sq-psn 13400680 pdn 0 pid 17847 comm ib_send_bw
> link efa_0/1 lqpn 1 type UNKNOWN state RTR sq-psn 0 pdn 1 pid 17820 comm ib_send_bw
>
> We can change the UNKNOWN to DRIVER/something else in userspace code.

We need to change it too.

Thanks