From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DB8C32751 for ; Wed, 31 Jul 2019 10:01:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF22B21842 for ; Wed, 31 Jul 2019 10:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564567279; bh=4I8iKUdPDwS1euox/Xalc3cSTELcSZBfgNdPY+k5IRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xGkwz6rYsafjKZ1y+8saKFUh8p0hhssGLF1S4whJpATGg26UaNZAJAKrnAkRkmTee e/ko068m2vyGKEpva02Uaf/P5zb5IDes8krkRZ9xdtmALHMrQk4wtnd4/9AKLJOzCb T0zy9ozKWxgK4SG7EF8+1R05nxHAsDUNeAd/02OY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729107AbfGaKBS (ORCPT ); Wed, 31 Jul 2019 06:01:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:45266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729106AbfGaKBS (ORCPT ); Wed, 31 Jul 2019 06:01:18 -0400 Received: from localhost (unknown [77.137.115.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA06521842; Wed, 31 Jul 2019 10:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564567277; bh=4I8iKUdPDwS1euox/Xalc3cSTELcSZBfgNdPY+k5IRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P47J8seH/68go6lEahie6Sbp0W9PYrMKfKcNO1xB/PLFbRbKMnYJICdoNo9UkPNGp q5vexRL/iYr7E1L1SlmMNsI+NQAL2v5c7uetS/LGoLbwUVM0btd8MqFQ1/0TgTtBj3 PaseO8xWyzzbtrop74we+4NmZIRBVvM/+10Abpko= Date: Wed, 31 Jul 2019 13:01:14 +0300 From: Leon Romanovsky To: Gal Pressman Cc: Jason Gunthorpe , Doug Ledford , linux-rdma@vger.kernel.org Subject: Re: [PATCH for-rc] RDMA/restrack: Track driver QP types in resource tracker Message-ID: <20190731100114.GR4878@mtr-leonro.mtl.com> References: <20190730110137.37826-1-galpress@amazon.com> <20190730133817.GC4878@mtr-leonro.mtl.com> <24f4f7e3-dada-5185-3988-2e821b321bc1@amazon.com> <20190730151936.GE4878@mtr-leonro.mtl.com> <1a7f11e2-ae90-3173-b24a-aae11731cad1@amazon.com> <20190731074612.GM4878@mtr-leonro.mtl.com> <20190731083448.GP4878@mtr-leonro.mtl.com> <08f3d48a-946a-677e-2103-5834ae0238d8@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08f3d48a-946a-677e-2103-5834ae0238d8@amazon.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jul 31, 2019 at 11:51:58AM +0300, Gal Pressman wrote: > On 31/07/2019 11:34, Leon Romanovsky wrote: > > On Wed, Jul 31, 2019 at 10:53:10AM +0300, Gal Pressman wrote: > >> On 31/07/2019 10:46, Leon Romanovsky wrote: > >>> On Wed, Jul 31, 2019 at 10:05:31AM +0300, Gal Pressman wrote: > >>>> On 30/07/2019 18:19, Leon Romanovsky wrote: > >>>>> On Tue, Jul 30, 2019 at 04:49:52PM +0300, Gal Pressman wrote: > >>>>>> On 30/07/2019 16:38, Leon Romanovsky wrote: > >>>>>>> On Tue, Jul 30, 2019 at 02:01:37PM +0300, Gal Pressman wrote: > >>>>>>>> The check for QP type different than XRC has wrongly excluded driver QP > >>>>>>>> types from the resource tracker. > >>>>>>>> > >>>>>>>> Fixes: 78a0cd648a80 ("RDMA/core: Add resource tracking for create and destroy QPs") > >>>>>>> > >>>>>>> It is a little bit over to say "wrongly". At that time, we did it on purpose > >>>>>>> because it was unclear how to represent such QP types to users and we didn't > >>>>>>> have vendor specific hooks introduced by Steve later on. > >>>>>> > >>>>>> It's very confusing to see a test running and zero QPs in "rdma res". > >>>>>> I'm fine with removing the "wrongly" :), but I still think this should be > >>>>>> targeted to for-rc as a bug fix. > >>>>> > >>>>> Yes, please remove "wrongly" and change Fixes line to be > >>>>> "Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")", > >>>>> because before addition of EFA driver all other drivers had QPs. > >>>> > >>>> How are DC QPs being counted? > >>> > >>> They were not counted on purpose. We didn't imagine acceptance of > >>> non-RDMA driver which doesn't support any standard QPs and doesn't > >>> work with kernel verbs. > >> > >> Running dcping/perftest over DC shows zero QPs? > > > > No, try it and you will see other QPs. > > > >> On purpose? > >> Sounds like a bug to me.. > > > > OK. > > Does OK mean you're OK with counting DC QPs after this patch? I'm OK with the idea, I'm not OK with the description. Thanks