[PATCH rdma-next 0/2] Enable QUERY_LAG over DEVX

[PATCH rdma-next 0/2] Enable QUERY_LAG over DEVX

[Leon Romanovsky]

From: Leon Romanovsky <leonro@mellanox.com>

Hi,

Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core,
but were not used and hence has wrong HW spec layout which is fixed in
first patch. The second patch actually makes this command available for
DEVX users.

Thanks

Mark Zhang (2):
  net/mlx5: Fix mlx5_ifc_query_lag_out_bits
  IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

 drivers/infiniband/hw/mlx5/devx.c | 1 +
 include/linux/mlx5/mlx5_ifc.h     | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

--
2.20.1

[PATCH mlx5-next 1/2] net/mlx5: Fix mlx5_ifc_query_lag_out_bits

[Leon Romanovsky]

From: Mark Zhang <markz@mellanox.com>

Remove the "reserved_at_40" field to match the device specification.

Fixes: 84df61ebc69b ("net/mlx5: Add HW interfaces used by LAG")
Signed-off-by: Mark Zhang <markz@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 include/linux/mlx5/mlx5_ifc.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 5eae8d734435..726790d9ef25 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -9572,8 +9572,6 @@ struct mlx5_ifc_query_lag_out_bits {

 	u8         syndrome[0x20];

-	u8         reserved_at_40[0x40];
-
 	struct mlx5_ifc_lagc_bits ctx;
 };

--
2.20.1

[PATCH rdma-next 2/2] IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

[Leon Romanovsky]

From: Mark Zhang <markz@mellanox.com>

The "MLX5_CMD_OP_QUERY_LAG" is one of the DEVX general commands, add it.

Fixes: 8aa8c95ce4cc ("IB/mlx5: Add support for DEVX general command")
Signed-off-by: Mark Zhang <markz@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/infiniband/hw/mlx5/devx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
index a527cf7f01ac..fd577ffd7864 100644
--- a/drivers/infiniband/hw/mlx5/devx.c
+++ b/drivers/infiniband/hw/mlx5/devx.c
@@ -930,6 +930,7 @@ static bool devx_is_general_cmd(void *in, struct mlx5_ib_dev *dev)
 	case MLX5_CMD_OP_QUERY_CONG_STATUS:
 	case MLX5_CMD_OP_QUERY_CONG_PARAMS:
 	case MLX5_CMD_OP_QUERY_CONG_STATISTICS:
+	case MLX5_CMD_OP_QUERY_LAG:
 		return true;
 	default:
 		return false;
-- 
2.20.1

Re: [PATCH rdma-next 0/2] Enable QUERY_LAG over DEVX

[Leon Romanovsky]

On Wed, Jul 31, 2019 at 02:40:12PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> Hi,
>
> Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core,
> but were not used and hence has wrong HW spec layout which is fixed in
> first patch. The second patch actually makes this command available for
> DEVX users.
>
> Thanks
>
> Mark Zhang (2):
>   net/mlx5: Fix mlx5_ifc_query_lag_out_bits
>   IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command

Both patches are applied to mlx5-next.

Thanks,

Re: [PATCH rdma-next 0/2] Enable QUERY_LAG over DEVX

[Jason Gunthorpe]

On Sun, Aug 04, 2019 at 05:28:50AM -0300, Leon Romanovsky wrote:
> On Wed, Jul 31, 2019 at 02:40:12PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Hi,
> >
> > Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core,
> > but were not used and hence has wrong HW spec layout which is fixed in
> > first patch. The second patch actually makes this command available for
> > DEVX users.
> >
> > Thanks
> >
> > Mark Zhang (2):
> >   net/mlx5: Fix mlx5_ifc_query_lag_out_bits
> >   IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command
> 
> Both patches are applied to mlx5-next.

Why the second one?

Jason

Re: [PATCH rdma-next 0/2] Enable QUERY_LAG over DEVX

[Leon Romanovsky]

On Tue, Aug 06, 2019 at 02:46:58PM +0000, Jason Gunthorpe wrote:
> On Sun, Aug 04, 2019 at 05:28:50AM -0300, Leon Romanovsky wrote:
> > On Wed, Jul 31, 2019 at 02:40:12PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@mellanox.com>
> > >
> > > Hi,
> > >
> > > Enable QUERY_LAG command over DEVX. That command was added to the mlx5_core,
> > > but were not used and hence has wrong HW spec layout which is fixed in
> > > first patch. The second patch actually makes this command available for
> > > DEVX users.
> > >
> > > Thanks
> > >
> > > Mark Zhang (2):
> > >   net/mlx5: Fix mlx5_ifc_query_lag_out_bits
> > >   IB/mlx5: Support MLX5_CMD_OP_QUERY_LAG as a DEVX general command
> >
> > Both patches are applied to mlx5-next.
>
> Why the second one?

It was one-liner patch and I preferred to save work from you.

Thanks

>
> Jason