From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F6BC433FF for ; Wed, 14 Aug 2019 02:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B3F82067D for ; Wed, 14 Aug 2019 02:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="IzzlmTyB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727198AbfHNCqh (ORCPT ); Tue, 13 Aug 2019 22:46:37 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:40879 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbfHNCqh (ORCPT ); Tue, 13 Aug 2019 22:46:37 -0400 Received: by mail-qt1-f194.google.com with SMTP id e8so8115160qtp.7 for ; Tue, 13 Aug 2019 19:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=pD/XpBOcxU6zmV0LLVzBEhXOXBom/NndH3aawH5g868=; b=IzzlmTyB3Xsgb8CSHmNFv3EZm3rd7s/+Rpz8uK8clVoBf/U3P301mjwFTXWDqj1oSM MQxMT8zWzlQhEBsElEoALqvNR+djrAIKRJ53nhPBVa5aeO26PnkJVrZgrXfbf8ebT6Kj r7qxLrrdPykTVPYutPYmHibq89a7LpC/Cl6EVfYmS3XrUeITn2zAbbnaM7MUJfmRf2S/ ToYyAmhLTfC//ryy8k1z/E2YdvDMFN+uUV418XIAbOviazwxZEJsChBJjfMfbLEv8cHK mvOsjt/5WsQYjAATOc8GbVcqfUrdB74JHXDEQ4L9B/LfbRRto9pY3SEndaiir56Sb9rv Qbvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=pD/XpBOcxU6zmV0LLVzBEhXOXBom/NndH3aawH5g868=; b=Su8NKKXuuNWTst6DwxPZg+1JX7gSkmf5ofYdyFC/rrXf2eod95ZJN5j2DMeJyjrU6J YCN7DvIB9xPWlE36C19VfR43tf1sQul0H8UOG6u67iXS3iDuyXqBFiX625a6f+Xk0DlA Cyo1kYM1M2AaMx9qJVN8/BN6AtCik0pQ18eKZ4YzuPT8cmFt7VzkfYnkFrByX1YLKtoc r1fjxkouAflGF7rwdB5CoFJCUibcl8CzskZM90bOumBzBQ2ocQ7AGFnkI55w3HQAecFU lteNEZSXEN4PxI073YKPNztOpLntm93wOLa+pvsfYWBkLlq8sGjLJolm5YB/mhSH3qdh IDYw== X-Gm-Message-State: APjAAAUpbAgZVdUAgFKxNtHhsVVhE6iP1UzN50sMlPzgO+Kl1uFWojfO TJnco4g83c9lEDnvti4FKkGCkQ== X-Google-Smtp-Source: APXvYqwZUhcYfqLZD1BmBDbDtrEp3VN4xaZXc5CMIUNdlUNrEwxJ99tUrtylVEq/hwrY8z7BcVtK5g== X-Received: by 2002:ac8:688:: with SMTP id f8mr36243068qth.130.1565750796315; Tue, 13 Aug 2019 19:46:36 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t26sm61485262qtc.95.2019.08.13.19.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2019 19:46:36 -0700 (PDT) Date: Tue, 13 Aug 2019 19:46:25 -0700 From: Jakub Kicinski To: Wenwen Wang Cc: Tariq Toukan , "David S. Miller" , netdev@vger.kernel.org (open list:MELLANOX ETHERNET DRIVER (mlx4_en)), linux-rdma@vger.kernel.org (open list:MELLANOX MLX4 core VPI driver), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2] net/mlx4_en: fix a memory leak bug Message-ID: <20190813194625.565e02b8@cakuba.netronome.com> In-Reply-To: <1565637095-7972-1-git-send-email-wenwen@cs.uga.edu> References: <1565637095-7972-1-git-send-email-wenwen@cs.uga.edu> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, 12 Aug 2019 14:11:35 -0500, Wenwen Wang wrote: > In mlx4_en_config_rss_steer(), 'rss_map->indir_qp' is allocated through > kzalloc(). After that, mlx4_qp_alloc() is invoked to configure RSS > indirection. However, if mlx4_qp_alloc() fails, the allocated > 'rss_map->indir_qp' is not deallocated, leading to a memory leak bug. > > To fix the above issue, add the 'qp_alloc_err' label to free > 'rss_map->indir_qp'. > > Fixes: 4931c6ef04b4 ("net/mlx4_en: Optimized single ring steering") > Signed-off-by: Wenwen Wang Applied, thanks.