From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F303C3A5A0 for ; Mon, 19 Aug 2019 13:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F52C20843 for ; Mon, 19 Aug 2019 13:52:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ndbx0dCJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbfHSNwP (ORCPT ); Mon, 19 Aug 2019 09:52:15 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:38864 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfHSNwP (ORCPT ); Mon, 19 Aug 2019 09:52:15 -0400 Received: by mail-qt1-f196.google.com with SMTP id x4so1931419qts.5 for ; Mon, 19 Aug 2019 06:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Bnb9CKB/tUC7U3C6zfvlJTsla79VOjwcHcog5ZBZ4GQ=; b=Ndbx0dCJ+2SuD3Msmy+Xj62gM8jjfCmnpKHbyJLn4KLWJUVBbvnd6rNUj1WSnft6hr IwFgxCanPilNhHpgRMEAXiMS2UMY/g5inXlwhDwiEUaBET+6IhTd97abOeo220f5cinQ m8/ndbjL9i88PW1P4iouqC4E5CCjIBG9ivqutDyRFmtgfB+k5B0GHSfSZsPl5wgQ53VB MsV+aMYhKYEsSQOJon9ohdFqHmQrNrpYq3DuoYxoTm3eWJa0KeNZI7RWbDTvofXUemuL oZTq+EvFrB2hrzDkxfFYniyByAu/9Nmc94VvTx/MDc5N6UEOv+FtmzOyFT5UPYMTHt98 GWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Bnb9CKB/tUC7U3C6zfvlJTsla79VOjwcHcog5ZBZ4GQ=; b=lGSOq9Re0WhJOk7qCKsaZHOMWM8q2ylKI5b9rlG4pD9WvSX+BqqF4RRjPKQjPqugCT Do1lkXnfqw50Paa9HF3mylSOuehWPPweGsTRmLxqESt5YTApzupsI/i8AadbNLaASire FxAiDXu+1bK6D0td6ePZpHqwPBixRznTs7z6wTlH0pYnF4DO4zs3j9PO7yaScQdqZaYY juRvOCgFi1+OgSDGG5+AXACyQ3RN8b29uM/hdPrdPyil8SfodtA+DxTzAM/xWaC5WMaA HSQEijRqn2Pg0sMWSNMD0uCdkVTanHTcxxST+nMywAGvwMU/tN+6tyLXm33lrQGlhtBo MRCw== X-Gm-Message-State: APjAAAXLggXYUCiBL5+BrI6mXV5mN56O0ZbAOnwEQ4rb11iYURTgbMGJ ohChgbcgn+K4VmtC/aNUo780sg== X-Google-Smtp-Source: APXvYqxcKG5ouN9UlYrki/9v0cHyD7bRPQtoBuOJvF3+cVrxMUun8T0S+0aa+uyjxp05nT/bh3K6Pw== X-Received: by 2002:ac8:4816:: with SMTP id g22mr21315595qtq.179.1566222734137; Mon, 19 Aug 2019 06:52:14 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id r15sm6997402qtp.94.2019.08.19.06.52.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Aug 2019 06:52:13 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hzi4z-0002ul-BL; Mon, 19 Aug 2019 10:52:13 -0300 Date: Mon, 19 Aug 2019 10:52:13 -0300 From: Jason Gunthorpe To: Bernard Metzler Cc: Geert Uytterhoeven , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse Message-ID: <20190819135213.GF5058@ziepe.ca> References: <20190819122456.GB5058@ziepe.ca> <20190819100526.13788-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Aug 19, 2019 at 01:36:11PM +0000, Bernard Metzler wrote: > >If the value is really a kernel pointer, then it ought to be printed > >with %p. We have been getting demanding on this point lately in RDMA > >to enforce the ability to keep kernel pointers secret. > > > >> - wqe->sqe.sge[0].laddr = (u64)&wqe->sqe.sge[1]; > >> + wqe->sqe.sge[0].laddr = (uintptr_t)&wqe->sqe.sge[1]; > > > >[..] > > > >> rv = siw_rx_kva(srx, > >> - (void *)(sge->laddr + frx->sge_off), > >> + (void *)(uintptr_t)(sge->laddr + frx->sge_off), > >> sge_bytes); > > > >Bernard, this is nonsense, what is going on here with sge->laddr that > >it can't be a void *? > > > siw_sge is defined in siw-abi.h. We make the address u64 to keep the ABI > arch independent. Eh? How does the siw-abi.h store a kernel pointer? Sounds like kernel and user types are being mixed. Jason