From: Yuval Shaia <yuval.shaia@oracle.com>
To: dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org,
monis@mellanox.com, parav@mellanox.com, danielj@mellanox.com,
kamalheib1@gmail.com, markz@mellanox.com,
swise@opengridcomputing.com, shamir.rabinovitch@oracle.com,
johannes.berg@intel.com, willy@infradead.org,
michaelgur@mellanox.com, markb@mellanox.com,
yuval.shaia@oracle.com, dan.carpenter@oracle.com,
bvanassche@acm.org, maxg@mellanox.com, israelr@mellanox.com,
galpress@amazon.com, denisd@mellanox.com, yuvalav@mellanox.com,
dennis.dalessandro@intel.com, will@kernel.org,
ereza@mellanox.com, jgg@mellanox.com, linux-rdma@vger.kernel.org
Subject: [PATCH v1 24/24] IB/uverbs: Add MR import verb
Date: Wed, 21 Aug 2019 17:21:25 +0300 [thread overview]
Message-ID: <20190821142125.5706-25-yuval.shaia@oracle.com> (raw)
In-Reply-To: <20190821142125.5706-1-yuval.shaia@oracle.com>
Implementation of new verb which enable to import ib_mr object.
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
drivers/infiniband/core/uverbs_cmd.c | 79 ++++++++++++++++++++++++++++
include/uapi/rdma/ib_user_verbs.h | 1 +
2 files changed, 80 insertions(+)
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 92f04e7360b6..5aaa6a7e129f 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -3875,6 +3875,15 @@ static void ib_uverbs_clone_ib_pd(union ib_uverbs_import_fr_fd_resp *resp,
resp->alloc_pd.pd_handle = handle;
}
+static void ib_uverbs_clone_ib_mr(union ib_uverbs_import_fr_fd_resp *resp,
+ struct ib_mr *mr,
+ __u32 handle)
+{
+ resp->reg_mr.lkey = mr->lkey;
+ resp->reg_mr.rkey = mr->rkey;
+ resp->reg_mr.mr_handle = handle;
+}
+
static int ib_uverbs_import_ib_pd(struct uverbs_attr_bundle *attrs)
{
union ib_uverbs_import_fr_fd_resp resp = {0};
@@ -3941,6 +3950,74 @@ static int ib_uverbs_import_ib_pd(struct uverbs_attr_bundle *attrs)
return ret;
}
+static int ib_uverbs_import_ib_mr(struct uverbs_attr_bundle *attrs)
+{
+ union ib_uverbs_import_fr_fd_resp resp = {0};
+ struct ib_uobject *src_uobj = NULL;
+ struct ib_uobject *dst_uobj = NULL;
+ struct ib_uverbs_import_fr_fd cmd;
+ struct ib_uverbs_file *src_file;
+ struct ib_device *ibdev;
+ struct ib_mr *mr;
+ struct file *filep;
+ int ret;
+
+ ret = uverbs_request(attrs, &cmd, sizeof(cmd));
+ if (ret)
+ return ret;
+
+ ret = ib_uverbs_import_lock(attrs, cmd.fd, UVERBS_OBJECT_MR,
+ cmd.handle, &src_uobj, &filep,
+ &src_file);
+ if (ret)
+ return ret;
+
+ mr = src_uobj->object;
+
+ dst_uobj = uobj_alloc(UVERBS_OBJECT_MR, attrs, &ibdev);
+ if (IS_ERR(dst_uobj)) {
+ ret = -ENOMEM;
+ goto uobj;
+ }
+
+ if (!ibdev->ops.clone_ib_mr) {
+ ret = -EINVAL;
+ goto uobj;
+ }
+
+ dst_uobj->object = src_uobj->object;
+ dst_uobj->refcnt = src_uobj->refcnt;
+
+ if (WARN_ON(!atomic_inc_not_zero(src_uobj->refcnt))) {
+ ret = -EINVAL;
+ goto uobj;
+ }
+
+ ret = ibdev->ops.clone_ib_mr(&attrs->driver_udata, mr);
+ if (ret)
+ goto uobj;
+
+ ib_uverbs_clone_ib_mr(&resp, dst_uobj->object, dst_uobj->id);
+
+ ret = uverbs_response(attrs, &resp, sizeof(resp));
+ if (ret)
+ goto uobj;
+
+ ret = uobj_alloc_commit(dst_uobj, attrs);
+
+ ib_uverbs_import_unlock(src_uobj, filep);
+
+ return ret;
+
+uobj:
+ ib_uverbs_import_unlock(src_uobj, filep);
+
+ if (!IS_ERR_OR_NULL(dst_uobj))
+ uobj_alloc_abort(dst_uobj, attrs);
+
+ return ret;
+}
+
static int ib_uverbs_import_fr_fd(struct uverbs_attr_bundle *attrs)
{
struct ib_uverbs_import_fr_fd cmd;
@@ -3953,6 +4030,8 @@ static int ib_uverbs_import_fr_fd(struct uverbs_attr_bundle *attrs)
switch (cmd.type) {
case UVERBS_OBJECT_PD:
return ib_uverbs_import_ib_pd(attrs);
+ case UVERBS_OBJECT_MR:
+ return ib_uverbs_import_ib_mr(attrs);
}
return -EINVAL;
diff --git a/include/uapi/rdma/ib_user_verbs.h b/include/uapi/rdma/ib_user_verbs.h
index 4274c40bcff8..cfd1a734d5f3 100644
--- a/include/uapi/rdma/ib_user_verbs.h
+++ b/include/uapi/rdma/ib_user_verbs.h
@@ -1311,6 +1311,7 @@ struct ib_uverbs_import_fr_fd {
union ib_uverbs_import_fr_fd_resp {
struct ib_uverbs_alloc_pd_resp alloc_pd;
+ struct ib_uverbs_reg_mr_resp reg_mr;
};
#define IB_DEVICE_NAME_MAX 64
--
2.20.1
next prev parent reply other threads:[~2019-08-21 14:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:21 [PATCH v1 00/24] Shared PD and MR Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 01/24] RDMA/uverbs: uobj_get_obj_read should return the ib_uobject Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 02/24] RDMA/uverbs: Delete the macro uobj_put_obj_read Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 03/24] RDMA/nldev: ib_pd can be pointed by multiple ib_ucontext Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 04/24] IB/{core,hw}: ib_pd should not have ib_uobject pointer Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 05/24] IB/core: ib_uobject need HW object reference count Yuval Shaia
2019-08-21 14:53 ` Jason Gunthorpe
2019-08-27 16:28 ` Yuval Shaia
2019-08-27 18:18 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 06/24] IB/uverbs: Helper function to initialize ufile member of uverbs_attr_bundle Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 07/24] IB/uverbs: Add context import lock/unlock helper Yuval Shaia
2019-08-21 14:57 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 08/24] IB/verbs: Prototype of HW object clone callback Yuval Shaia
2019-08-21 14:59 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 09/24] IB/core: Install clone ib_pd in device ops Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 10/24] IB/mlx4: Add implementation of clone_pd callback Yuval Shaia
2019-08-21 14:59 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 11/24] IB/mlx5: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 12/24] RDMA/rxe: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 13/24] IB/uverbs: Add clone reference counting to ib_pd Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 14/24] IB/uverbs: Add PD import verb Yuval Shaia
2019-08-21 15:00 ` Jason Gunthorpe
2019-08-21 14:21 ` [PATCH v1 15/24] IB/mlx4: Enable import from FD verb Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 16/24] IB/mlx5: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 17/24] RDMA/rxe: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 18/24] IB/core: ib_mr should not have ib_uobject pointer Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 19/24] IB/core: Install clone ib_mr in device ops Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 20/24] IB/mlx4: Add implementation of clone_pd callback Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 21/24] IB/mlx5: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 22/24] RDMA/rxe: " Yuval Shaia
2019-08-21 14:21 ` [PATCH v1 23/24] IB/uverbs: Add clone reference counting to ib_mr Yuval Shaia
2019-08-21 14:21 ` Yuval Shaia [this message]
2019-08-21 14:50 ` [PATCH v1 00/24] Shared PD and MR Jason Gunthorpe
2019-08-22 8:50 ` Yuval Shaia
2019-08-21 23:37 ` Ira Weiny
2019-08-22 8:41 ` Yuval Shaia
2019-08-22 14:15 ` Doug Ledford
2019-08-26 9:35 ` Yuval Shaia
2019-08-22 16:58 ` Ira Weiny
2019-08-22 17:03 ` Jason Gunthorpe
2019-08-22 20:10 ` Weiny, Ira
2019-08-23 11:57 ` Jason Gunthorpe
2019-08-23 21:33 ` Weiny, Ira
2019-08-26 10:58 ` Yuval Shaia
2019-08-26 10:29 ` Yuval Shaia
2019-08-26 12:26 ` Jason Gunthorpe
2019-08-26 9:51 ` Yuval Shaia
2019-08-26 10:04 ` Yuval Shaia
2019-08-26 10:10 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821142125.5706-25-yuval.shaia@oracle.com \
--to=yuval.shaia@oracle.com \
--cc=bvanassche@acm.org \
--cc=dan.carpenter@oracle.com \
--cc=danielj@mellanox.com \
--cc=denisd@mellanox.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=ereza@mellanox.com \
--cc=galpress@amazon.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=johannes.berg@intel.com \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=markz@mellanox.com \
--cc=maxg@mellanox.com \
--cc=michaelgur@mellanox.com \
--cc=monis@mellanox.com \
--cc=parav@mellanox.com \
--cc=shamir.rabinovitch@oracle.com \
--cc=swise@opengridcomputing.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yuvalav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox