Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Bernard Metzler <bmt@zurich.ibm.com>
Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, geert@linux-m68k.org
Subject: Re: [PATCH v2] RDMA/siw: fix 64/32bit pointer inconsistency
Date: Thu, 22 Aug 2019 16:08:29 +0300	[thread overview]
Message-ID: <20190822130829.GE29433@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190820172221.6274-1-bmt@zurich.ibm.com>

On Tue, Aug 20, 2019 at 07:22:21PM +0200, Bernard Metzler wrote:
> Fixes improper casting between addresses and unsigned types.
> Changes siw_pbl_get_buffer() function to return appropriate
> dma_addr_t, and not u64.
>
> In debug prints, all potentially kernel private variables
> are printed as void * to allow keeping that information
> secret.

It is done by using %pK and not by strange casting.
https://elixir.bootlin.com/linux/v5.3-rc5/source/Documentation/core-api/printk-formats.rst#L113

Thanks

  reply	other threads:[~2019-08-22 13:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 17:22 [PATCH v2] RDMA/siw: fix 64/32bit pointer inconsistency Bernard Metzler
2019-08-22 13:08 ` Leon Romanovsky [this message]
2019-08-22 16:46   ` Bernard Metzler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822130829.GE29433@mtr-leonro.mtl.com \
    --to=leon@kernel.org \
    --cc=bmt@zurich.ibm.com \
    --cc=geert@linux-m68k.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox