Re: [PATCH rdma-core 03/14] build: Add pyverbs-based test to the build

[Leon Romanovsky <leonro@mellanox.com>]

On Tue, Aug 20, 2019 at 01:00:47PM +0000, Noa Osherovich wrote:
> On 8/19/2019 4:50 PM, Jason Gunthorpe wrote:
>
> > I'd prefer run_tests to be in the tests directory..
> >
> > Jason
>
> PR was updated

1.
IMHO, run_tests.py should be placed inside tests directory too and not
only installed into tests/.

➜  rdma-core git:(noaos-pr-tests) ✗ pwd
/images/leonro/src/rdma-core
➜  rdma-core git:(noaos-pr-tests) ✗ ls -al | grep  run_tests.py
-rw-rw-r--.  1 leonro leonro   549 Aug 22 18:59 run_tests.py

Expected
➜  rdma-core git:(noaos-pr-tests) ✗ ls -al tests/ | grep  run_tests.py
-rw-rw-r--.  1 leonro leonro   549 Aug 22 18:59 run_tests.py

2.
Execution of run_tests.py produces a lot of untracked filed
➜  rdma-core git:(noaos-pr-tests) ✗ git st
On branch noaos-pr-tests
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	pyverbs/__init__.pyc
	pyverbs/pyverbs_error.pyc
	tests/__init__.pyc
	tests/base.pyc
	tests/test_addr.pyc
	tests/test_cq.pyc
	tests/test_device.pyc
	tests/test_mr.pyc
	tests/test_odp.pyc
	tests/test_pd.pyc
	tests/test_qp.pyc

3. run_tests.py lacks of python3 shebang
4. Attempt to run on system without ib* modules causes to awful splat.
Is it expected?
t:(noaos-pr-tests) python ./run_tests.py
EEEEEEE
======================================================================
ERROR: test_mr (unittest.loader.ModuleImportFailure)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_mr
Traceback (most recent call last):
  File "/usr/lib64/python2.7/unittest/loader.py", line 254, in   _find_tests
    module = self._get_module_from_name(name)
  File "/usr/lib64/python2.7/unittest/loader.py", line 232, in _get_module_from_name
    __import__(name)
  File "/images/leonro/src/rdma-core/tests/test_mr.py", line 10, in <module>
    from tests.base import PyverbsAPITestCase
  File "/images/leonro/src/rdma-core/tests/base.py", line 7, in <module>
    from pyverbs.qp import QPCap, QPInitAttr, QPAttr, QP
ImportError: No module named qp

.....

----------------------------------------------------------------------
Ran 7 tests in 0.000s

FAILED (errors=7)

Thanks

>
> Thanks,
> Noa
>