From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E3EC3A59F for ; Mon, 26 Aug 2019 12:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1800F2184D for ; Mon, 26 Aug 2019 12:20:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fnMzsCTr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731850AbfHZMU6 (ORCPT ); Mon, 26 Aug 2019 08:20:58 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:45187 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730287AbfHZMU6 (ORCPT ); Mon, 26 Aug 2019 08:20:58 -0400 Received: by mail-qt1-f194.google.com with SMTP id k13so17541250qtm.12 for ; Mon, 26 Aug 2019 05:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IInbJuct5ufzKNiytsnk+jMIYv1V6eVTEaTj38ohm3M=; b=fnMzsCTram2mN7X12asMshdyTXllFMcSBIdA21KFh1RFEex2/5FeKlO+9rtE32Hfem jNFRntwunRTt9MR1Ovw/7sG8gRUDu02VVxJVeHApVsYUYSL3ColhOVAIONzU/OwgzIsI Cf+dbVDkOq6orHb9v/8o9ozQW9LemkmRD/qs4cgkUG9GO8bMKSsQ5fVmxRZ8QKmTd/UN cMzUj24siEC0zPzjoKcmIhXTIs2pUPmj3ydsCJXBTyle1aaPAglspzS3pqQgQ9jGMdgs V8/0FEQAaqOhMwcD4fjLClL9PYtQeZh0epvkMiiCdtfvZJMAYEZM7IJ41fzr+ZyQcPqf fuvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IInbJuct5ufzKNiytsnk+jMIYv1V6eVTEaTj38ohm3M=; b=Nfk6wZ9aM6HJNQZ6IGw6/MD4RIvwPUSSOGgjxmQB57VVZPz4bRXHYZVSAS9GFU0Wro dqTKf6qwAWz2HSojbBiVC/+ulCyDeUvIaSG4G328eOfPc2sySl/WeOYbzj3z8yW0munH fEq6xcl4Auj+nVN+hHQfsvJNLaKMDUs2yKW1A+Y3ycbR7WaM8Xxp+cts1tKU5PR2FtQo 3UO0LoPHwhUBdP/lI+OuTEUr4RLr6LOZcEjeAigyk0jsIixOECgBWXBElzdwvZ6AKRAw 4hTkgK/TLIee10+qAodWdPb3XSHkYEbH9qE8FG8EFsiGRRxVbM3Of+g3A8HmyhPjGyjZ 8/bw== X-Gm-Message-State: APjAAAWhRkpTYU2YCgF7lh5XxzCYG6wniKYLs5mVWlgfIRb3d+fh8/2Q 8JhFxNbQlpNQ5JkICrMQDYAGLg== X-Google-Smtp-Source: APXvYqz+8moKXNMjENzuAiUz9yUTyRo1T98w+98Tx3SfRXc69ey23f/HpA4QXKYMoXk3ry4w8yOQ3g== X-Received: by 2002:ac8:73c7:: with SMTP id v7mr14706237qtp.9.1566822056913; Mon, 26 Aug 2019 05:20:56 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-216-168.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.216.168]) by smtp.gmail.com with ESMTPSA id q6sm6213402qke.109.2019.08.26.05.20.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Aug 2019 05:20:56 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1i2DzT-0007A1-Sv; Mon, 26 Aug 2019 09:20:55 -0300 Date: Mon, 26 Aug 2019 09:20:55 -0300 From: Jason Gunthorpe To: Souptick Joarder Cc: leon@kernel.org, Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] IB/mlx5: Convert to use vm_map_pages_zero() Message-ID: <20190826122055.GA27349@ziepe.ca> References: <1566713247-23873-1-git-send-email-jrdr.linux@gmail.com> <20190825194354.GC21239@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Aug 26, 2019 at 01:32:09AM +0530, Souptick Joarder wrote: > On Mon, Aug 26, 2019 at 1:13 AM Jason Gunthorpe wrote: > > > > On Sun, Aug 25, 2019 at 11:37:27AM +0530, Souptick Joarder wrote: > > > First, length passed to mmap is checked explicitly against > > > PAGE_SIZE. > > > > > > Second, if vma->vm_pgoff is passed as non zero, it would return > > > error. It appears like driver is expecting vma->vm_pgoff to > > > be passed as 0 always. > > > > ? pg_off is not zero > > Sorry, I mean, driver has a check against non zero to return error -EOPNOTSUPP > which means in true scenario driver is expecting vma->vm_pgoff should be passed > as 0. get_index is masking vm_pgoff, it is not 0 Jason