From: Yuval Shaia <yuval.shaia@oracle.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"oulijun@huawei.com" <oulijun@huawei.com>,
"xavier.huwei@huawei.com" <xavier.huwei@huawei.com>,
"leon@kernel.org" <leon@kernel.org>,
Parav Pandit <parav@mellanox.com>,
Mark Zhang <markz@mellanox.com>,
"swise@opengridcomputing.com" <swise@opengridcomputing.com>,
"galpress@amazon.com" <galpress@amazon.com>,
Israel Rukshin <israelr@mellanox.com>,
Moni Shoua <monis@mellanox.com>, Max Gurtovoy <maxg@mellanox.com>,
"kamalheib1@gmail.com" <kamalheib1@gmail.com>,
Denis Drozdov <denisd@mellanox.com>,
Yuval Avnery <yuvalav@mellanox.com>,
"dennis.dalessandro@intel.com" <dennis.dalessandro@intel.com>,
Erez Alfasi <ereza@mellanox.com>,
"will@kernel.org" <will@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"srabinov7@gmail.com" <srabinov7@gmail.com>,
"santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>,
Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
Subject: Re: [PATCH v1 5/5] RDMA/nldev: ib_pd can be pointed by multiple ib_ucontext
Date: Wed, 28 Aug 2019 21:56:46 +0300 [thread overview]
Message-ID: <20190828185645.GA4799@lap1> (raw)
In-Reply-To: <20190828135307.GH914@mellanox.com>
On Wed, Aug 28, 2019 at 01:53:12PM +0000, Jason Gunthorpe wrote:
> On Wed, Aug 28, 2019 at 12:15:33PM +0300, Yuval Shaia wrote:
> > static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > struct rdma_restrack_entry *res, uint32_t port)
> > {
> > struct ib_pd *pd = container_of(res, struct ib_pd, res);
> > struct ib_device *dev = pd->device;
> > + struct nlattr *table_attr = NULL;
> > + struct nlattr *entry_attr = NULL;
> > + struct context_id *ctx_id;
> > + struct context_id *tmp;
> > + LIST_HEAD(pd_context_ids);
> > + int ctx_count = 0;
> >
> > if (has_cap_net_admin) {
> > if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY,
> > @@ -633,10 +709,38 @@ static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
> > if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_PDN, res->id))
> > goto err;
> >
> > - if (!rdma_is_kernel_res(res) &&
> > - nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_CTXN,
> > - pd->uobject->context->res.id))
> > - goto err;
>
> How do earlier patches compile?
They did not
>
> Jason
next prev parent reply other threads:[~2019-08-28 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:15 [PATCH v1 0/5] Take out ucontext from HW objects Yuval Shaia
2019-08-28 9:15 ` [PATCH v1 1/5] RDMA/uverbs: uobj_get_obj_read should return the ib_uobject Yuval Shaia
2019-08-28 9:15 ` [PATCH v1 2/5] RDMA/uverbs: Delete the macro uobj_put_obj_read Yuval Shaia
2019-08-28 9:15 ` [PATCH v1 3/5] IB/{core,hw}: ib_pd should not have ib_uobject pointer Yuval Shaia
2019-08-28 9:15 ` [PATCH v1 4/5] IB/core: ib_mr " Yuval Shaia
2019-08-28 13:48 ` Jason Gunthorpe
2019-08-28 9:15 ` [PATCH v1 5/5] RDMA/nldev: ib_pd can be pointed by multiple ib_ucontext Yuval Shaia
2019-08-28 13:53 ` Jason Gunthorpe
2019-08-28 18:56 ` Yuval Shaia [this message]
2019-08-28 19:28 ` Jason Gunthorpe
2019-08-29 7:13 ` Yuval Shaia
2019-08-29 14:27 ` Jason Gunthorpe
2019-09-01 13:10 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828185645.GA4799@lap1 \
--to=yuval.shaia@oracle.com \
--cc=denisd@mellanox.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=ereza@mellanox.com \
--cc=galpress@amazon.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markz@mellanox.com \
--cc=maxg@mellanox.com \
--cc=monis@mellanox.com \
--cc=oulijun@huawei.com \
--cc=parav@mellanox.com \
--cc=santosh.shilimkar@oracle.com \
--cc=shamir.rabinovitch@oracle.com \
--cc=srabinov7@gmail.com \
--cc=swise@opengridcomputing.com \
--cc=will@kernel.org \
--cc=xavier.huwei@huawei.com \
--cc=yuvalav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox