From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1636DC4CEC7 for ; Mon, 16 Sep 2019 06:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D53B6214C6 for ; Mon, 16 Sep 2019 06:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568616512; bh=qjavJG0clGn/ep2R+HjCfih45FUkK2h7e204CKMOeRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2FspeXDlVCRm4EUmTudw9uci0GEpgoTt6xnA0ldJOF68lqfl+GFz2Aj56AINMpziq sHr75ljVd3qobPl2+3qGgnUfvrlQ2LnBMmSwrBG6fgaG8ihZ1UwTKDq0wCldNQTxnn 55f3POhyW399gP64le2DaQSdrvcG6yXgBKCGfLDE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729543AbfIPGsc (ORCPT ); Mon, 16 Sep 2019 02:48:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:52082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfIPGsb (ORCPT ); Mon, 16 Sep 2019 02:48:31 -0400 Received: from localhost (unknown [77.137.89.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E01CF20890; Mon, 16 Sep 2019 06:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568616511; bh=qjavJG0clGn/ep2R+HjCfih45FUkK2h7e204CKMOeRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=duGS/M2EtKD+InlYZ6iCNSXLWL5pua+KT94o3eY1gXffwVVoO/eyR67+yUHmSWFz5 tcnXcRBkddA5FKlWu/3ZZrNFv/lkFW9yYaVF2AdbS4hlRwvWjWxod3jcFIh8FpVpLi pYvsk6NxEXlVqIRH+3HCYRPCgojmveC81BEkcVW0= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , RDMA mailing list , Daniel Jurgens , Danit Goldberg , Yishai Hadas Subject: [PATCH 2/2] IB/mlx5: Free mpi in mp_slave mode Date: Mon, 16 Sep 2019 09:48:18 +0300 Message-Id: <20190916064818.19823-3-leon@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190916064818.19823-1-leon@kernel.org> References: <20190916064818.19823-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Danit Goldberg ib_add_slave_port() allocates a multiport struct but never frees it. Don't leak memory, free the allocated mpi struct during driver unload. Fixes: 32f69e4be269 ("{net, IB}/mlx5: Manage port association for multiport RoCE") Signed-off-by: Danit Goldberg --- drivers/infiniband/hw/mlx5/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 0569bcab02d4..14807ea8dc3f 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -6959,6 +6959,7 @@ static void mlx5_ib_remove(struct mlx5_core_dev *mdev, void *context) mlx5_ib_unbind_slave_port(mpi->ibdev, mpi); list_del(&mpi->list); mutex_unlock(&mlx5_ib_multiport_mutex); + kfree(mpi); return; } -- 2.20.1