From: Honggang LI <honli@redhat.com>
To: bvanassche@acm.org
Cc: linux-rdma@vger.kernel.org, Honggang Li <honli@redhat.com>
Subject: [rdma-core patch] srp_daemon: fix a double free segment fault for ibsrpdm
Date: Thu, 19 Sep 2019 14:40:45 +0800 [thread overview]
Message-ID: <20190919064045.23193-1-honli@redhat.com> (raw)
From: Honggang Li <honli@redhat.com>
Command: ./ibsrpdm -d /dev/infiniband/umadX
Invalid free() / delete / delete[] / realloc()
at 0x4C320DC: free (vg_replace_malloc.c:540)
by 0x403BBB: free_config (srp_daemon.c:1811)
by 0x4031BE: ibsrpdm (srp_daemon.c:2113)
by 0x4031BE: main (srp_daemon.c:2153)
Address 0x5ee5fd0 is 0 bytes inside a block of size 16 free'd
at 0x4C320DC: free (vg_replace_malloc.c:540)
by 0x404851: translate_umad_to_ibdev_and_port (srp_daemon.c:729)
by 0x404851: set_conf_dev_and_port (srp_daemon.c:1586)
by 0x403171: ibsrpdm (srp_daemon.c:2092)
by 0x403171: main (srp_daemon.c:2153)
Block was alloc'd at
at 0x4C30EDB: malloc (vg_replace_malloc.c:309)
by 0x40478D: translate_umad_to_ibdev_and_port (srp_daemon.c:698)
by 0x40478D: set_conf_dev_and_port (srp_daemon.c:1586)
by 0x403171: ibsrpdm (srp_daemon.c:2092)
by 0x403171: main (srp_daemon.c:2153)
Signed-off-by: Honggang Li <honli@redhat.com>
---
srp_daemon/srp_daemon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
index 337b21c7..f0bcf923 100644
--- a/srp_daemon/srp_daemon.c
+++ b/srp_daemon/srp_daemon.c
@@ -727,6 +727,7 @@ end:
if (ret) {
free(*ibport);
free(*ibdev);
+ *ibdev = NULL;
}
free(class_dev_path);
--
2.21.0
next reply other threads:[~2019-09-19 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 6:40 Honggang LI [this message]
2019-09-20 16:21 ` [rdma-core patch] srp_daemon: fix a double free segment fault for ibsrpdm Bart Van Assche
2019-09-24 8:11 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919064045.23193-1-honli@redhat.com \
--to=honli@redhat.com \
--cc=bvanassche@acm.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox