public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Yuval Basson <ybason@marvell.com>
To: <dledford@redhat.com>, <jgg@ziepe.ca>
Cc: <leon@kernel.org>, <mkalderon@marvell.com>,
	<linux-rdma@vger.kernel.org>, Yuval Basson <ybason@marvell.com>,
	Ariel Elior <aelior@marvell.com>
Subject: [PATCH rdma-next] RDMA/core: Fix find_gid_index to use the proper API to retrieve the vlan ID
Date: Wed, 25 Sep 2019 14:23:01 +0300	[thread overview]
Message-ID: <20190925112301.10440-1-ybason@marvell.com> (raw)

When working over a macvlan device which was itself
created over a vlan device, the roce CM traffic should use
the vlan from the lower vlan device, but instead it simply queries
the macvlan device as to whether it is itself a vlan device. 
Since it is not, the roce CM traffic is sent without any vlan, which
causes it not to be accepted by the peer which is running directly
over a vlan device, and will thus only accept roce CM traffic carrying
the vlan.

Fixes: dbf727de7440 ("Use GID table in AH creation and dmac resolution")
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Yuval Basson <ybason@marvell.com>
---
 drivers/infiniband/core/verbs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index f974b68..1d2d9be0 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -662,13 +662,13 @@ static bool find_gid_index(const union ib_gid *gid,
 			   void *context)
 {
 	struct find_gid_index_context *ctx = context;
+	u16 vlan_id;
 
 	if (ctx->gid_type != gid_attr->gid_type)
 		return false;
 
-	if ((!!(ctx->vlan_id != 0xffff) == !is_vlan_dev(gid_attr->ndev)) ||
-	    (is_vlan_dev(gid_attr->ndev) &&
-	     vlan_dev_vlan_id(gid_attr->ndev) != ctx->vlan_id))
+	rdma_read_gid_l2_fields(gid_attr, &vlan_id, NULL);
+	if (ctx->vlan_id != vlan_id)
 		return false;
 
 	return true;
-- 
1.8.3.1


             reply	other threads:[~2019-09-25 11:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 11:23 Yuval Basson [this message]
2019-09-25 17:17 ` [PATCH rdma-next] RDMA/core: Fix find_gid_index to use the proper API to retrieve the vlan ID Parav Pandit
2019-09-26  8:00   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190925112301.10440-1-ybason@marvell.com \
    --to=ybason@marvell.com \
    --cc=aelior@marvell.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mkalderon@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox