* [PATCH] net/mlx5: Fixed a typo in a comment in esw_del_uc_addr()
@ 2019-09-21 0:49 Qing Huang
2019-10-08 0:38 ` Qing Huang
0 siblings, 1 reply; 4+ messages in thread
From: Qing Huang @ 2019-09-21 0:49 UTC (permalink / raw)
To: linux-rdma
Changed "managerss" to "managers".
Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the esw manager vport")
Signed-off-by: Qing Huang <qing.huang@oracle.com>
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
index 81e03e4..48642b8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr)
u16 vport = vaddr->vport;
int err = 0;
- /* Skip mlx5_mpfs_del_mac for eswitch managerss,
+ /* Skip mlx5_mpfs_del_mac for eswitch managers,
* it is already done by its netdev in mlx5e_execute_l2_action
*/
if (!vaddr->mpfs || esw->manager_vport == vport)
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net/mlx5: Fixed a typo in a comment in esw_del_uc_addr()
2019-09-21 0:49 [PATCH] net/mlx5: Fixed a typo in a comment in esw_del_uc_addr() Qing Huang
@ 2019-10-08 0:38 ` Qing Huang
2019-10-08 5:47 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Qing Huang @ 2019-10-08 0:38 UTC (permalink / raw)
To: linux-rdma
I know this is not critical. Maybe someone can merge this or fix it with
other commits? Thanks.
On 9/20/19 5:49 PM, Qing Huang wrote:
> Changed "managerss" to "managers".
>
> Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the esw manager vport")
> Signed-off-by: Qing Huang <qing.huang@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> index 81e03e4..48642b8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr)
> u16 vport = vaddr->vport;
> int err = 0;
>
> - /* Skip mlx5_mpfs_del_mac for eswitch managerss,
> + /* Skip mlx5_mpfs_del_mac for eswitch managers,
> * it is already done by its netdev in mlx5e_execute_l2_action
> */
> if (!vaddr->mpfs || esw->manager_vport == vport)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/mlx5: Fixed a typo in a comment in esw_del_uc_addr()
2019-10-08 0:38 ` Qing Huang
@ 2019-10-08 5:47 ` Leon Romanovsky
2019-10-15 20:26 ` Saeed Mahameed
0 siblings, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2019-10-08 5:47 UTC (permalink / raw)
To: Qing Huang; +Cc: linux-rdma, linux-netdev, Saeed Mahameed
On Mon, Oct 07, 2019 at 05:38:55PM -0700, Qing Huang wrote:
> I know this is not critical. Maybe someone can merge this or fix it with
> other commits? Thanks.
It is not "linux-rdma", but netdev. Your chances will be much higher if
you use get_maintainer.pl and put relevant mailing lists together with
maintainers in TO/CC parts of an email.
Saeed will return from vacation and will take it to his net-next part.
Thanks
>
> On 9/20/19 5:49 PM, Qing Huang wrote:
> > Changed "managerss" to "managers".
> >
> > Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the esw manager vport")
> > Signed-off-by: Qing Huang <qing.huang@oracle.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > index 81e03e4..48642b8 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr)
> > u16 vport = vaddr->vport;
> > int err = 0;
> > - /* Skip mlx5_mpfs_del_mac for eswitch managerss,
> > + /* Skip mlx5_mpfs_del_mac for eswitch managers,
> > * it is already done by its netdev in mlx5e_execute_l2_action
> > */
> > if (!vaddr->mpfs || esw->manager_vport == vport)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/mlx5: Fixed a typo in a comment in esw_del_uc_addr()
2019-10-08 5:47 ` Leon Romanovsky
@ 2019-10-15 20:26 ` Saeed Mahameed
0 siblings, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2019-10-15 20:26 UTC (permalink / raw)
To: leon@kernel.org, qing.huang@oracle.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org
On Tue, 2019-10-08 at 08:47 +0300, Leon Romanovsky wrote:
> On Mon, Oct 07, 2019 at 05:38:55PM -0700, Qing Huang wrote:
> > I know this is not critical. Maybe someone can merge this or fix it
> > with
> > other commits? Thanks.
>
> It is not "linux-rdma", but netdev. Your chances will be much higher
> if
> you use get_maintainer.pl and put relevant mailing lists together
> with
> maintainers in TO/CC parts of an email.
>
> Saeed will return from vacation and will take it to his net-next
> part.
>
Applied to net-next-mlx5, please submit all mlx5 core (net) patches to
netdev mailing list in the future to make it easier to find and review
these patches.
Thanks,
Saeed.
> Thanks
>
> > On 9/20/19 5:49 PM, Qing Huang wrote:
> > > Changed "managerss" to "managers".
> > >
> > > Fixes: a1b3839ac4a4 ("net/mlx5: E-Switch, Properly refer to the
> > > esw manager vport")
> > > Signed-off-by: Qing Huang <qing.huang@oracle.com>
> > > ---
> > > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > > b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > > index 81e03e4..48642b8 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
> > > @@ -530,7 +530,7 @@ static int esw_del_uc_addr(struct
> > > mlx5_eswitch *esw, struct vport_addr *vaddr)
> > > u16 vport = vaddr->vport;
> > > int err = 0;
> > > - /* Skip mlx5_mpfs_del_mac for eswitch managerss,
> > > + /* Skip mlx5_mpfs_del_mac for eswitch managers,
> > > * it is already done by its netdev in
> > > mlx5e_execute_l2_action
> > > */
> > > if (!vaddr->mpfs || esw->manager_vport == vport)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-15 20:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-21 0:49 [PATCH] net/mlx5: Fixed a typo in a comment in esw_del_uc_addr() Qing Huang
2019-10-08 0:38 ` Qing Huang
2019-10-08 5:47 ` Leon Romanovsky
2019-10-15 20:26 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).