From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6060C4360C for ; Thu, 10 Oct 2019 09:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 917AC21D7B for ; Thu, 10 Oct 2019 09:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570698184; bh=iBWylZV4s1mHX5S95KeH+Xo4wwtrt2IgNiuLobs/Idw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wIxv8+SzKVfE5LQ97uoXeaWpKMiuZ7ENu6O4zbwl0tYOXN5DPTlOJbtHNs8AXf0LP ES+lxgSj9+TDRR4WeGx8I3oas/wAYdHxRxBEJrlOwMb6QR/TedjD9opyzljROg3365 OLlvDE3L9UZVzkIIfgQIPjMUmbOL0U6MqmAoJuRE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388387AbfJJJDD (ORCPT ); Thu, 10 Oct 2019 05:03:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:39948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387799AbfJJJDC (ORCPT ); Thu, 10 Oct 2019 05:03:02 -0400 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB57D2190F; Thu, 10 Oct 2019 09:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570698182; bh=iBWylZV4s1mHX5S95KeH+Xo4wwtrt2IgNiuLobs/Idw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LO7iTcUkpmtNBog809AER8WW6bPARx29sOi6ePoVjuuZiycYNoCjPcTTi1Ji+JsCJ 2yZNwI77Us6jhKMOlsd/02pqIhkqayWsPQYdB5aNQ5roSMfbHlVC6EfZ4ynfHbTVaF JnJF4EdQu/seJ5i8JGe1jYYCkfFsF5M5widkA+mw= Date: Thu, 10 Oct 2019 12:02:59 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , RDMA mailing list , Erez Alfasi Subject: Re: [PATCH rdma-next v2 4/4] RDMA/nldev: Provide MR statistics Message-ID: <20191010090259.GK5855@unreal> References: <20191006155139.30632-1-leon@kernel.org> <20191006155139.30632-5-leon@kernel.org> <20191009144012.GJ22714@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009144012.GJ22714@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Oct 09, 2019 at 02:40:16PM +0000, Jason Gunthorpe wrote: > On Sun, Oct 06, 2019 at 06:51:39PM +0300, Leon Romanovsky wrote: > > From: Erez Alfasi > > > > Add RDMA nldev netlink interface for dumping MR > > statistics information. > > > > Output example: > > ereza@dev~$: ./ibv_rc_pingpong -o -P -s 500000000 > > local address: LID 0x0001, QPN 0x00008a, PSN 0xf81096, GID :: > > > > ereza@dev~$: rdma stat show mr > > dev mlx5_0 mrn 2 page_faults 122071 page_invalidations 0 > > prefetched_pages 122071 > > > > Signed-off-by: Erez Alfasi > > Signed-off-by: Leon Romanovsky > > drivers/infiniband/core/device.c | 1 + > > drivers/infiniband/core/nldev.c | 41 ++++++++++++++++++++++--- > > drivers/infiniband/hw/mlx5/main.c | 2 ++ > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 ++ > > drivers/infiniband/hw/mlx5/restrack.c | 44 +++++++++++++++++++++++++++ > > include/rdma/ib_verbs.h | 7 +++++ > > include/rdma/restrack.h | 3 ++ > > 7 files changed, 96 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c > > index a667636f74bf..2e53aa25f0c7 100644 > > +++ b/drivers/infiniband/core/device.c > > @@ -2606,6 +2606,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops) > > SET_DEVICE_OP(dev_ops, drain_sq); > > SET_DEVICE_OP(dev_ops, enable_driver); > > SET_DEVICE_OP(dev_ops, fill_res_entry); > > + SET_DEVICE_OP(dev_ops, fill_stat_entry); > > SET_DEVICE_OP(dev_ops, get_dev_fw_str); > > SET_DEVICE_OP(dev_ops, get_dma_mr); > > SET_DEVICE_OP(dev_ops, get_hw_stats); > > diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c > > index 6114465959e1..1d9d89fd9ce9 100644 > > +++ b/drivers/infiniband/core/nldev.c > > @@ -454,6 +454,14 @@ static bool fill_res_entry(struct ib_device *dev, struct sk_buff *msg, > > return dev->ops.fill_res_entry(msg, res); > > } > > > > +static bool fill_stat_entry(struct ib_device *dev, struct sk_buff *msg, > > + struct rdma_restrack_entry *res) > > +{ > > + if (!dev->ops.fill_stat_entry) > > + return false; > > + return dev->ops.fill_stat_entry(msg, res); > > +} > > Why do we need this function called in only one place? Be consistent with other fill_... functions. > > Jason