From: Leon Romanovsky <leonro@mellanox.com>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@mellanox.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>,
Michael Guralnik <michaelgur@mellanox.com>
Subject: Re: [PATCH rdma-next 2/2] IB/mlx5: Test write combining support
Date: Tue, 22 Oct 2019 12:35:26 +0000 [thread overview]
Message-ID: <20191022123523.GH4853@unreal> (raw)
In-Reply-To: <20191020064400.8344-3-leon@kernel.org>
On Sun, Oct 20, 2019 at 09:44:00AM +0300, Leon Romanovsky wrote:
> From: Michael Guralnik <michaelgur@mellanox.com>
>
> Add a test in mlx5_ib initialization process to test whether
> write-combining is supported on the machine.
> The test will run as part of the enable_driver callback to ensure that
> the test runs after the device is setup and can create and modify the
> QP needed, but runs before the device is exposed to the users.
>
> The test opens UD QP and posts NOP WQEs, the WQE written to the BlueFlame
> is different from the WQE in memory, requesting CQE only on the BlueFlame
> WQE. By checking whether we received a completion on one of these WQEs we
> can know if BlueFlame succeeded and whether write-combining is supported.
>
> Change reporting of BlueFlame support to be dependent on write-combining
> support.
>
> Signed-off-by: Michael Guralnik <michaelgur@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 15 +-
> drivers/infiniband/hw/mlx5/mem.c | 200 +++++++++++++++++++++++++++
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 6 +
> drivers/infiniband/hw/mlx5/qp.c | 6 +-
> 4 files changed, 224 insertions(+), 3 deletions(-)
>
We found statistical failure with this patch and I'll resend it.
Thanks
prev parent reply other threads:[~2019-10-22 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 6:43 [PATCH rdma-next 0/2] Set BlueFlame size based on memory properties Leon Romanovsky
2019-10-20 6:43 ` [PATCH rdma-next 1/2] IB/mlx5: Align usage of QP1 create flags with rest of mlx5 defines Leon Romanovsky
2019-10-22 19:40 ` Jason Gunthorpe
2019-10-20 6:44 ` [PATCH rdma-next 2/2] IB/mlx5: Test write combining support Leon Romanovsky
2019-10-22 12:35 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022123523.GH4853@unreal \
--to=leonro@mellanox.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox