public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Yuval Shaia <yuval.shaia@oracle.com>,
	bharat@chelsio.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] iw_cxgb3: Remove the iw_cxgb3 provider code
Date: Wed, 23 Oct 2019 11:30:29 -0300	[thread overview]
Message-ID: <20191023143029.GI23952@ziepe.ca> (raw)
In-Reply-To: <20191023054802.GI4853@unreal>

On Wed, Oct 23, 2019 at 08:48:02AM +0300, Leon Romanovsky wrote:
> On Tue, Oct 22, 2019 at 02:58:21PM -0300, Jason Gunthorpe wrote:
> > On Tue, Oct 22, 2019 at 01:57:18PM -0400, Doug Ledford wrote:
> > > On Tue, 2019-10-22 at 20:47 +0300, Yuval Shaia wrote:
> > > > diff --git a/kernel-headers/rdma/rdma_user_ioctl_cmds.h b/kernel-
> > > > headers/rdma/rdma_user_ioctl_cmds.h
> > > > index b8bb285f..b2680051 100644
> > > > +++ b/kernel-headers/rdma/rdma_user_ioctl_cmds.h
> > > > @@ -88,7 +88,6 @@ enum rdma_driver_id {
> > > >         RDMA_DRIVER_UNKNOWN,
> > > >         RDMA_DRIVER_MLX5,
> > > >         RDMA_DRIVER_MLX4,
> > > > -       RDMA_DRIVER_CXGB3,
> > > >         RDMA_DRIVER_CXGB4,
> > > >         RDMA_DRIVER_MTHCA,
> > > >         RDMA_DRIVER_BNXT_RE,
> > >
> > > This is the same bug the kernel patch had.  We can't change that enum.
> >
> > This patch shouldn't touch the kernel headers, delete the driver, then
> > we will get the kernel header changes on the next resync.
> 
> If you are doing that, can you please delete nes provider too?
> Maybe ipathverbs too?

ipathverbs is qib, iirc

Jason

  reply	other threads:[~2019-10-23 14:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22 17:47 [PATCH] iw_cxgb3: Remove the iw_cxgb3 provider code Yuval Shaia
2019-10-22 17:57 ` Doug Ledford
2019-10-22 17:58   ` Jason Gunthorpe
2019-10-23  5:33     ` Yuval Shaia
2019-10-23  5:48     ` Leon Romanovsky
2019-10-23 14:30       ` Jason Gunthorpe [this message]
2019-10-23  5:47   ` Yuval Shaia
2019-10-23  6:20 ` Potnuri Bharat Teja
2019-10-23 14:50   ` Yuval Shaia
2019-10-24 10:18     ` Potnuri Bharat Teja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023143029.GI23952@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=bharat@chelsio.com \
    --cc=dledford@redhat.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox