Re: [PATCH for-next] selftests: rdma: Add rdma tests

[Kamal Heib <kamalheib1@gmail.com>]

On Thu, Oct 24, 2019 at 09:39:09AM +0300, Leon Romanovsky wrote:
> On Wed, Oct 23, 2019 at 11:10:08PM +0300, Kamal Heib wrote:
> > On Wed, Oct 23, 2019 at 02:42:19PM -0300, Jason Gunthorpe wrote:
> > > On Wed, Oct 23, 2019 at 08:39:54PM +0300, Kamal Heib wrote:
> > > > Add a new directory to house the rdma specific tests and add the first
> > > > rdma_dev.sh test that checks the renaming and setting of adaptive
> > > > moderation using the rdma tool for the available RDMA devices in the
> > > > system.
> > >
> > > What is this actually testing? rdmatool?
> > >
> >
> > This is a very basic test that uses the rdmatool for checking two of the
> > RDMA devices functionalities.
> >
> > > This seems like a very strange kselftest to me.
> > >
> >
> > Basically, you can take a look into other subsystems selftests (e.g.
> > net) to see that it not that strange :-).
> 
> Yeah, selftests is in-kernel dumpster, everything goes in. It doesn't
> mean we should follow this path too. The in-kernel tests are great to
> check interfaces and not external tools.
>

OK, I see that you don't like the idea of using external/Userspace tools.

So, what do you suggest?! 

> >
> > Yes, the first test is very basic, but the idea behind it is to utilize
> > the kernel selftests infrastructure to test the rdma subsystem, I plan to
> > introduce more tests in the near future, hopefully other folks from the
> > community will join me too.
> 
> You don't have any version checks, the idea that you can test latest
> kernel features with installed "rdmatool" in distro is a little bit over
> optimistic.
> 
> >
> > Thanks,
> > Kamal
> >
> > > Jason