* [PATCH for-next] RDMA/siw: Fix post_recv QP state locking
@ 2019-10-25 14:29 Bernard Metzler
2019-10-27 6:33 ` Leon Romanovsky
2019-10-28 17:37 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Bernard Metzler @ 2019-10-25 14:29 UTC (permalink / raw)
To: linux-rdma; +Cc: dan.carpenter, Bernard Metzler
Do not release qp state lock if not previously acquired.
Fixes: cf049bb31f71 ("RDMA/siw: Fix SQ/RQ drain logic")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
---
drivers/infiniband/sw/siw/siw_verbs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
index c0574ddc98fa..726a5924ea13 100644
--- a/drivers/infiniband/sw/siw/siw_verbs.c
+++ b/drivers/infiniband/sw/siw/siw_verbs.c
@@ -990,7 +990,6 @@ int siw_post_receive(struct ib_qp *base_qp, const struct ib_recv_wr *wr,
}
if (!qp->kernel_verbs) {
siw_dbg_qp(qp, "no kernel post_recv for user mapped sq\n");
- up_read(&qp->state_lock);
*bad_wr = wr;
return -EINVAL;
}
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-next] RDMA/siw: Fix post_recv QP state locking
2019-10-25 14:29 [PATCH for-next] RDMA/siw: Fix post_recv QP state locking Bernard Metzler
@ 2019-10-27 6:33 ` Leon Romanovsky
2019-10-28 17:37 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2019-10-27 6:33 UTC (permalink / raw)
To: Bernard Metzler; +Cc: linux-rdma, dan.carpenter
On Fri, Oct 25, 2019 at 04:29:03PM +0200, Bernard Metzler wrote:
> Do not release qp state lock if not previously acquired.
>
> Fixes: cf049bb31f71 ("RDMA/siw: Fix SQ/RQ drain logic")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
> drivers/infiniband/sw/siw/siw_verbs.c | 1 -
> 1 file changed, 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for-next] RDMA/siw: Fix post_recv QP state locking
2019-10-25 14:29 [PATCH for-next] RDMA/siw: Fix post_recv QP state locking Bernard Metzler
2019-10-27 6:33 ` Leon Romanovsky
@ 2019-10-28 17:37 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2019-10-28 17:37 UTC (permalink / raw)
To: Bernard Metzler; +Cc: linux-rdma, dan.carpenter
On Fri, Oct 25, 2019 at 04:29:03PM +0200, Bernard Metzler wrote:
> Do not release qp state lock if not previously acquired.
>
> Fixes: cf049bb31f71 ("RDMA/siw: Fix SQ/RQ drain logic")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/sw/siw/siw_verbs.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-28 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-25 14:29 [PATCH for-next] RDMA/siw: Fix post_recv QP state locking Bernard Metzler
2019-10-27 6:33 ` Leon Romanovsky
2019-10-28 17:37 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox