From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1242ECA9EC1 for ; Mon, 28 Oct 2019 15:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCA3B21835 for ; Mon, 28 Oct 2019 15:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572276374; bh=TSW9WUhS+AO6NSG6qmWuwjzu0w8iv1aBAXI7F9W8B5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zwzzdicucViYPEX+gCqGbr6iVddxDkN2sA4jxRRUwd2cHVMIRcIlcUoMKcs/v+g32 Wmtuws82wjpnekwB0dqtbI555RxB4FVZbMRwqy0FHr80AfP44OxyXW8cryK+8Cnqbl kCkoPxdPNFA8F8Ow5y0u+mw/SzqND8NedoglQ298= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726538AbfJ1P0O (ORCPT ); Mon, 28 Oct 2019 11:26:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:52572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbfJ1P0O (ORCPT ); Mon, 28 Oct 2019 11:26:14 -0400 Received: from localhost (unknown [77.137.89.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED58921783; Mon, 28 Oct 2019 15:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572276373; bh=TSW9WUhS+AO6NSG6qmWuwjzu0w8iv1aBAXI7F9W8B5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aub9s7mYM9+pBbVpOdhsi1e1Om0bnJY3S1l0rsjdakbrqe0ewS/bQOAXfncq8Winh 3JXntQhVxzoHaoHbzSri679xtP/y67OLfdLvwjkERwI6XjJ95mgkUxHab5vMmsMi37 /QnvDav/NEPNI69Hy3FNTzvFX8576bq9Kj21hFwc= Date: Mon, 28 Oct 2019 17:26:09 +0200 From: Leon Romanovsky To: "Hefty, Sean" Cc: Doug Ledford , Jason Gunthorpe , RDMA mailing list Subject: Re: [PATCH rdma-next] RDMA/ucma: Protect kernel from QPN larger than declared in IBTA Message-ID: <20191028152609.GK5146@unreal> References: <20191028134444.25537-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Oct 28, 2019 at 03:09:26PM +0000, Hefty, Sean wrote: > > IBTA declares QPN as 24bits, mask input to ensure that kernel > > doesn't get higher bits. > > > > Fixes: 75216638572f ("RDMA/cma: Export rdma cm interface to userspace") > > Signed-off-by: Leon Romanovsky > > --- > > * Not fully tested yet, passed sanity tests for now. > > --- > > drivers/infiniband/core/ucma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c > > index 0274e9b704be..57e68491a2fd 100644 > > --- a/drivers/infiniband/core/ucma.c > > +++ b/drivers/infiniband/core/ucma.c > > @@ -1045,7 +1045,7 @@ static void ucma_copy_conn_param(struct rdma_cm_id *id, > > dst->retry_count = src->retry_count; > > dst->rnr_retry_count = src->rnr_retry_count; > > dst->srq = src->srq; > > - dst->qp_num = src->qp_num; > > + dst->qp_num = src->qp_num & 0xFFFFFF; > > Why not isolate IBTA restrictions in the ib_cm? AFAIK, there are many places in IB/core code which assume that type of restriction, so it is safer and cleaner to sanitize input as early as possible. Thanks