Re: [PATCH 09/19] drm/via: set FOLL_PIN via pin_user_pages_fast()

Daniel Vetter
2019-11-04T18:11:05Z

On Thu, Oct 31, 2019 at 04:36:28PM -0700, Ira Weiny wrote:
> On Wed, Oct 30, 2019 at 03:49:20PM -0700, John Hubbard wrote:
> > Convert drm/via to use the new pin_user_pages_fast() call, which sets
> > FOLL_PIN. Setting FOLL_PIN is now required for code that requires
> > tracking of pinned pages, and therefore for any code that calls
> > put_user_page().
> >
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>

No one's touching the via driver anymore, so feel free to merge this
through whatever tree suits best (aka I'll drop this on the floor and
forget about it now).

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

>
> > Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> > ---
> > drivers/gpu/drm/via/via_dmablit.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c
> > index 3db000aacd26..37c5e572993a 100644
> > --- a/drivers/gpu/drm/via/via_dmablit.c
> > +++ b/drivers/gpu/drm/via/via_dmablit.c
> > @@ -239,7 +239,7 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer)
> > vsg->pages = vzalloc(array_size(sizeof(struct page *), vsg->num_pages));
> > if (NULL == vsg->pages)
> > return -ENOMEM;
> > - ret = get_user_pages_fast((unsigned long)xfer->mem_addr,
> > + ret = pin_user_pages_fast((unsigned long)xfer->mem_addr,
> > vsg->num_pages,
> > vsg->direction == DMA_FROM_DEVICE ? FOLL_WRITE : 0,
> > vsg->pages);
> > --
> > 2.23.0
> >

--
Daniel Vetter
Software Engineer, Intel Corporation