Re: [PATCH 11/19] net/xdp: set FOLL_PIN via pin_user_pages()

Ira Weiny
2019-10-31T23:37:51Z

On Wed, Oct 30, 2019 at 03:49:22PM -0700, John Hubbard wrote:
> Convert net/xdp to use the new pin_longterm_pages() call, which sets
> FOLL_PIN. Setting FOLL_PIN is now required for code that requires
> tracking of pinned pages.
>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> net/xdp/xdp_umem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c
> index 16d5f353163a..4d56dfb1139a 100644
> --- a/net/xdp/xdp_umem.c
> +++ b/net/xdp/xdp_umem.c
> @@ -285,8 +285,8 @@ static int xdp_umem_pin_pages(struct xdp_umem *umem)
> return -ENOMEM;
>
> down_read(&current->mm->mmap_sem);
> - npgs = get_user_pages(umem->address, umem->npgs,
> - gup_flags | FOLL_LONGTERM, &umem->pgs[0], NULL);
> + npgs = pin_longterm_pages(umem->address, umem->npgs, gup_flags,
> + &umem->pgs[0], NULL);
> up_read(&current->mm->mmap_sem);
>
> if (npgs != umem->npgs) {
> --
> 2.23.0
>