From: Leon Romanovsky <leon@kernel.org>
To: Potnuri Bharat Teja <bharat@chelsio.com>
Cc: jgg@ziepe.ca, dledford@redhat.com, linux-rdma@vger.kernel.org,
nirranjan@chelsio.com
Subject: Re: [PATCH rdma-core] cxgb4: free appropriate pointer in error case
Date: Mon, 4 Nov 2019 13:45:48 +0200 [thread overview]
Message-ID: <20191104114548.GA100753@unreal> (raw)
In-Reply-To: <1572866050-29952-1-git-send-email-bharat@chelsio.com>
On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote:
> Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs")
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
We are not super-excited to see patches with empty commit message.
Care to send PR to rdma-core? It will be easier for us to merge it.
Thanks
> providers/cxgb4/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c
> index 7f5955449ca1..4d02c7a91892 100644
> --- a/providers/cxgb4/dev.c
> +++ b/providers/cxgb4/dev.c
> @@ -203,9 +203,9 @@ err_free:
> if (rhp->cqid2ptr)
> free(rhp->cqid2ptr);
> if (rhp->qpid2ptr)
> - free(rhp->cqid2ptr);
> + free(rhp->qpid2ptr);
> if (rhp->mmid2ptr)
> - free(rhp->cqid2ptr);
> + free(rhp->mmid2ptr);
> verbs_uninit_context(&context->ibv_ctx);
> free(context);
> return NULL;
> --
> 2.3.9
>
next prev parent reply other threads:[~2019-11-04 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 11:14 [PATCH rdma-core] cxgb4: free appropriate pointer in error case Potnuri Bharat Teja
2019-11-04 11:45 ` Leon Romanovsky [this message]
2019-11-04 12:21 ` Potnuri Bharat Teja
2019-11-04 15:56 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104114548.GA100753@unreal \
--to=leon@kernel.org \
--cc=bharat@chelsio.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox