From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42EE5C432C3 for ; Wed, 20 Nov 2019 13:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A9B322506 for ; Wed, 20 Nov 2019 13:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XI0v4WKh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730316AbfKTNl3 (ORCPT ); Wed, 20 Nov 2019 08:41:29 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:38550 "EHLO mail-qk1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728898AbfKTNl3 (ORCPT ); Wed, 20 Nov 2019 08:41:29 -0500 Received: by mail-qk1-f175.google.com with SMTP id e2so21232389qkn.5 for ; Wed, 20 Nov 2019 05:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=icDSw0kK1puulej1TqOEDk3c9ykeB0QO2JJKV2fLt6E=; b=XI0v4WKhD8Cz4abX0PIeCnnAyhgnhXmBc5jzD4GJFV15LHSCDfrn/rw45O/qWmSV87 NRH6ekwJtoP9l4ez2QKoB/LebojlYRWTFPFso0jD3L0JtOHl+KItmV+zLqNIyizR1c+X 42tlV15avvRFcCo4Ik6esLJFUFM0nyWU8E62tZqBEVo5A5raZmHb2rZdMNXTqmq2rhGe D7l7eLsQkbxspF+k3oFO7iRYVVUCAHwct2XVE3FisfNQd56KbAtggm2T8f8c/vYQ4H5s rmIKJ7h5+IC1EzoTM0XIvo6ZVlbjz/ChLVXEv0uPChtBq5u/n/p0192rcAF9ZgsrXpri SpmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=icDSw0kK1puulej1TqOEDk3c9ykeB0QO2JJKV2fLt6E=; b=k+HcCEe+ZPXgACyQ2LoGpWGHfeEdFU0kB2Wa5Fg5sKAxJHeSrXd1wVOEfYWGN5+ID/ kcTmBTEQNiWyA3J6f8Usxrru/i6B2Ln9LiqR0Yn+q+3+kPjlOSyM9vI9IZHIAe7ob+71 jOuDMeO1uAsOZe88PrZ4gmaReb3Y50zbHc9XcaMrElEXt9mAMJXDJRK7IzrASqdrmVcW 4l24Ews5ZE6wGong9ORFK98nyinRGYE359flHnzfxjnOlr/pPncc4ggxkU6ghEB90WFp 7WB1KcZwZTC89oKNyuZv18ml7b76NWYMzde/7b2BYaUTMgQxqWpD70o4T202FQ+z9Va+ 13FQ== X-Gm-Message-State: APjAAAVowMtR7L8ElbhxHOBuxG2Ir8EPrEO+JHL3JD+Iqzq/9AY9CNct UpEOW7oAhhPyWFoZrlOTEgGgUg== X-Google-Smtp-Source: APXvYqwV55Shx1sqh/BT/rqphjh2QnRXE1xCrFZaY4WpYzL41lQGLAunB0X8ZMgXo02n55DAUssHBg== X-Received: by 2002:a37:a010:: with SMTP id j16mr2437128qke.84.1574257288122; Wed, 20 Nov 2019 05:41:28 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id x12sm11869585qkf.84.2019.11.20.05.41.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 05:41:27 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iXQEY-0006bD-Q0; Wed, 20 Nov 2019 09:41:26 -0400 Date: Wed, 20 Nov 2019 09:41:26 -0400 From: Jason Gunthorpe To: Jason Wang Cc: Parav Pandit , Jeff Kirsher , "davem@davemloft.net" , "gregkh@linuxfoundation.org" , Dave Ertman , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , Kiran Patil , "Michael S. Tsirkin" , Alex Williamson , Tiwei Bie Subject: Re: [net-next v2 1/1] virtual-bus: Implementation of Virtual Bus Message-ID: <20191120134126.GD22515@ziepe.ca> References: <13946106-dab2-6bbe-df79-ca6dfdeb4c51@redhat.com> <743601510.35622214.1574219728585.JavaMail.zimbra@redhat.com> <21106743-57b2-2ca7-258c-e37a0880c70f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21106743-57b2-2ca7-258c-e37a0880c70f@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Nov 20, 2019 at 12:07:59PM +0800, Jason Wang wrote: > 1) create sub fucntion and do must to have pre configuration through devlink > 2) only after sub function is created one more available instance was added > and shown through sysfs > 3) user can choose to create and use that mdev instance as it did for other > type of device like vGPU > 4) devlink can still use to report other stuffs Why do we want the extra step #3? The user already indicated they want a mdev via #1 I have the same question for the PF and VF cases, why doesn't a mdev get created automatically when the VF is probed? Why does this need the guid stuff? The guid stuff was intended for, essentially, multi-function devices that could be sliced up, I don't think it makes sense to use it for single-function VF devices like the ICF driver. Overall the guid thing should be optional. Drivers providing mdev should be able to use another scheme, like devlink, to on demand create their mdevs. Jason