From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Max Hirsch <max.hirsch@gmail.com>,
Doug Ledford <dledford@redhat.com>,
Parav Pandit <parav@mellanox.com>,
Steve Wise <swise@opengridcomputing.com>,
Bart Van Assche <bvanassche@acm.org>,
Danit Goldberg <danitg@mellanox.com>,
Matthew Wilcox <willy@infradead.org>,
Dag Moxnes <dag.moxnes@oracle.com>,
Myungho Jung <mhjungk@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cma: Fix checkpatch error
Date: Thu, 12 Dec 2019 15:41:52 +0200 [thread overview]
Message-ID: <20191212134152.GB67461@unreal> (raw)
In-Reply-To: <e5123cbb-9871-d9c3-62e9-5b3172d1adf8@amazon.com>
On Thu, Dec 12, 2019 at 02:10:12PM +0200, Gal Pressman wrote:
> On 12/12/2019 10:49, Leon Romanovsky wrote:
> > On Wed, Dec 11, 2019 at 12:26:54PM -0400, Jason Gunthorpe wrote:
> >> On Wed, Dec 11, 2019 at 11:16:26AM +0000, Max Hirsch wrote:
> >>> When running checkpatch on cma.c the following error was found:
> >>
> >> I think checkpatch will complain about your patch, did you run it?
> >
> > Jason, Doug
> >
> > I would like to ask to refrain from accepting checkpatch.pl patches
> > which are not part of other large submission. Such standalone cleanups
> > do more harm than actual benefit from them for old and more or less
> > stable code (e.g. RDMA-CM).
>
> Sounds like a great approach to prevent new developers from contributing code.
> You have to start somewhere and checkpatch patches are a good entry point for
> such developers, discouraging them will only hurt us in the long term.
We have staging tree where new developer can train their checkpatch patches.
What about fixing smatch and sparse errors? It doesn't require HW for
that and much better entry point for the new developers.
>
> Linus had an interesting post on the subject:
> https://lkml.org/lkml/2004/12/20/255
We are in 2019 and our opinions, Linus's back 15 years ago and mine can be different.
Thanks
prev parent reply other threads:[~2019-12-12 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 11:16 [PATCH] RDMA/cma: Fix checkpatch error Max Hirsch
2019-12-11 16:26 ` Jason Gunthorpe
2019-12-12 1:33 ` Max Hirsch
2019-12-18 12:52 ` Jason Gunthorpe
2019-12-12 8:49 ` Leon Romanovsky
2019-12-12 12:10 ` Gal Pressman
2019-12-12 12:28 ` Max Hirsch
2019-12-12 13:47 ` Leon Romanovsky
2019-12-12 13:41 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212134152.GB67461@unreal \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=dag.moxnes@oracle.com \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=max.hirsch@gmail.com \
--cc=mhjungk@gmail.com \
--cc=parav@mellanox.com \
--cc=swise@opengridcomputing.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).