Re: [PATCH v11 06/25] mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERM

John Hubbard
2019-12-18T22:18:47Z

On 12/18/19 8:19 AM, Kirill A. Shutemov wrote:
...
>> diff --git a/mm/gup.c b/mm/gup.c
>> index 3ecce297a47f..c0c56888e7cc 100644
>> --- a/mm/gup.c
>> +++ b/mm/gup.c
>> @@ -29,6 +29,13 @@ struct follow_page_context {
>> unsigned int page_mask;
>> };
>>
>> +static __always_inline long __gup_longterm_locked(struct task_struct *tsk,
>> + struct mm_struct *mm,
>> + unsigned long start,
>> + unsigned long nr_pages,
>> + struct page **pages,
>> + struct vm_area_struct **vmas,
>> + unsigned int flags);
>
> Any particular reason for the forward declaration? Maybe move
> get_user_pages_remote() down?
>

Yes, that's exactly why: I was thinking it would be cleaner to put in the
forward declaration, rather than moving code blocks, but either way seems
reasonable. I'll go ahead and move the code blocks and delete the forward
declaration, now that someone has weighed in in favor of that.

thanks,
--
John Hubbard
NVIDIA