Re: [PATCH v6 12/25] rtrs: server: sysfs interface functions

Jinpu Wang
2020-01-07T14:40:59Z

On Thu, Jan 2, 2020 at 11:06 PM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 12/30/19 2:29 AM, Jack Wang wrote:
> > +static struct kobj_attribute rtrs_srv_disconnect_attr =
> > + __ATTR(disconnect, 0644,
> > + rtrs_srv_disconnect_show, rtrs_srv_disconnect_store);
>
> Could __ATTR_RW() have been used here?
>
> > +static struct kobj_attribute rtrs_srv_hca_port_attr =
> > + __ATTR(hca_port, 0444, rtrs_srv_hca_port_show, NULL);
>
> Could __ATTR_RO() have been used here?
>
> Thanks,
>
> Bart.
both case can be used, but I prefer to keep the rtrs_srv prefix.
Thanks Bart.