Re: [PATCH v6 16/25] rnbd: client: private header with client structs and functions

Bart Van Assche
2020-01-02T22:37:31Z

On 12/30/19 2:29 AM, Jack Wang wrote:
> +struct rnbd_iu {
> + union {
> + struct request *rq; /* for block io */
> + void *buf; /* for user messages */
> + };
> + struct rtrs_permit *permit;
> + union {
> + /* use to send msg associated with a dev */
> + struct rnbd_clt_dev *dev;
> + /* use to send msg associated with a sess */
> + struct rnbd_clt_session *sess;
> + };
> + blk_status_t status;
> + struct scatterlist sglist[BMAX_SEGMENTS];
> + struct work_struct work;
> + int errno;
> + struct rnbd_iu_comp comp;
> + atomic_t refcount;
> +};

This data structure includes both a blk_status_t and an errno value. Can
these two members be combined into a single member?

Thanks,

Bart.