Re: [PATCH v6 13/25] rtrs: include client and server modules into kernel compilation

Bart Van Assche
2020-01-02T23:01:28Z

On 12/30/19 2:29 AM, Jack Wang wrote:
> +config INFINIBAND_RTRS
> + tristate
> + depends on INFINIBAND_ADDR_TRANS
> +
> +config INFINIBAND_RTRS_CLIENT
> + tristate "RTRS client module"
> + depends on INFINIBAND_ADDR_TRANS
> + select INFINIBAND_RTRS
> + help
> + RDMA transport client module.
> +
> + RTRS client allows for simplified data transfer and connection
> + establishment over RDMA (InfiniBand, RoCE, iWarp). Uses BIO-like
> + READ/WRITE semantics and provides multipath capabilities.

What does "simplified" mean in this context? I'm concerned that
including that word will cause confusion. How about writing that RTRS
implements a reliable transport layer and also multipathing
functionality and that it is intended to be the base layer for a block
storage initiator over RDMA?

> +config INFINIBAND_RTRS_SERVER
> + tristate "RTRS server module"
> + depends on INFINIBAND_ADDR_TRANS
> + select INFINIBAND_RTRS
> + help
> + RDMA transport server module.
> +
> + RTRS server module processing connection and IO requests received
> + from the RTRS client module, it will pass the IO requests to its
> + user eg. RNBD_server.

Users who see these help texts will be left wondering what RTRS stands
for. Please add some text that explains what the RTRS abbreviation
stands for.

Thanks,

Bart.