From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B3F6C33C8C for ; Tue, 7 Jan 2020 13:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D280120656 for ; Tue, 7 Jan 2020 13:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="E8kbk40g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbgAGNrg (ORCPT ); Tue, 7 Jan 2020 08:47:36 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:52530 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727806AbgAGNrf (ORCPT ); Tue, 7 Jan 2020 08:47:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SxuV5Cc5QkSPqHbEGgQj9EU3pDPkAmFnLH+JYodGQyw=; b=E8kbk40gT4pnda12zv8jnIz0F RmntHd+qs4bBQEUKZw0q5F3Tw2sh2Zzc8BsAkoz1YFNQFEjvJ8gQ9cmtS7vPYtVInHNcjJoJ4kCvj 79rK+GZGEIzOXLjwPMfEXYfkSQgs4J+bCSmbBSRl6QDwklrR4TqnAQXrkQvTiirxZZuPoaTup+NhC aBW91rU051rpAnjcCvvP2gbI5w7wSg6fKtv9iNgzYPRqjot0vj9zKTi7HcLmflSLiN3jLzXYtPS0Q EdsYjCKd0Kq/D3Ww2MgpbKCGA0qp3mrmkqdv/ZHeCrM6hXgvzZjgLbkYrZVUz4bTgKYNgjGuDq8MA xFGhNdMAw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iopCi-0001bD-QA; Tue, 07 Jan 2020 13:47:28 +0000 Date: Tue, 7 Jan 2020 05:47:28 -0800 From: Christoph Hellwig To: Chuck Lever Cc: Leon Romanovsky , Jason Gunthorpe , "dledford@redhat.com" , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH v9 0/3] Proposed trace points for RDMA/core Message-ID: <20200107134728.GA375@infradead.org> References: <20191216154924.21101.64860.stgit@manet.1015granger.net> <20191218002214.GL16762@mellanox.com> <20191218053644.GJ66555@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Dec 18, 2019 at 08:20:20AM -0500, Chuck Lever wrote: > > > > On Dec 18, 2019, at 12:36 AM, Leon Romanovsky wrote: > > > > On Wed, Dec 18, 2019 at 12:22:19AM +0000, Jason Gunthorpe wrote: > >> On Mon, Dec 16, 2019 at 10:53:43AM -0500, Chuck Lever wrote: > >>> Hey y'all- > >>> > >>> Refresh of the RDMA/core trace point patches. Anything else needed > >>> before these are acceptable? > >> > >> Can Leon compile and run it yet? > > > > Nope, it is enough to apply first patch to see compilation error. > > I've never seen that here. There is another report of this problem > with an earlier version of the series, so I thought it had been > resolved. > > I'll look into it. You tend to need a line like: ccflags-y += -I $(srctree)/$(src) # needed for trace events to ensure the trace header actually gets included for out of source tree builds. Or move the trace header to include/trave/events/. I find that annoying for simple modules, but for a subsystem where the trace header might be spread over various directories that might end up being much easier.