Re: [PATCH net-next 03/14] qed: FW 8.42.2.0 Queue Manager changes

kbuild test robot
2020-01-24T19:10:23Z

[-- Attachment #1: Type: text/plain, Size: 7674 bytes --]

Hi Michal,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on linus/master v5.5-rc7 next-20200121]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Michal-Kalderon/qed-Utilize-FW-8-42-2-0/20200124-181924
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9bbc8be29d66cc34b650510f2c67b5c55235fe5d
config: i386-randconfig-d002-20200124 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_hw_init_common':
>> drivers/net/ethernet/qlogic/qed/qed_dev.c:2666:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^

vim +2666 drivers/net/ethernet/qlogic/qed/qed_dev.c

60afed72f51c74 Tomer Tayar 2017-04-06 2596
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2597 static int qed_hw_init_common(struct qed_hwfn *p_hwfn,
1a635e488ecf6f Yuval Mintz 2016-08-15 2598 struct qed_ptt *p_ptt, int hw_mode)
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2599 {
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2600 struct qed_qm_info *qm_info = &p_hwfn->qm_info;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2601 struct qed_qm_common_rt_init_params params;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2602 struct qed_dev *cdev = p_hwfn->cdev;
9c79ddaa0f962d Mintz, Yuval 2017-03-14 2603 u8 vf_id, max_num_vfs;
dbb799c39717e7 Yuval Mintz 2016-06-03 2604 u16 num_pfs, pf_id;
1408cc1fa48c54 Yuval Mintz 2016-05-11 2605 u32 concrete_fid;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2606 int rc = 0;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2607
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2608 qed_init_cau_rt_data(cdev);
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2609
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2610 /* Program GTT windows */
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2611 qed_gtt_init(p_hwfn);
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2612
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2613 if (p_hwfn->mcp_info) {
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2614 if (p_hwfn->mcp_info->func_info.bandwidth_max)
c7281d591332b9 Gustavo A. R. Silva 2018-03-22 2615 qm_info->pf_rl_en = true;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2616 if (p_hwfn->mcp_info->func_info.bandwidth_min)
c7281d591332b9 Gustavo A. R. Silva 2018-03-22 2617 qm_info->pf_wfq_en = true;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2618 }
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2619
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2620 memset(&params, 0, sizeof(params));
78cea9ffaa34d2 Tomer Tayar 2017-05-23 2621 params.max_ports_per_engine = p_hwfn->cdev->num_ports_in_engine;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2622 params.max_phys_tcs_per_port = qm_info->max_phys_tcs_per_port;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2623 params.pf_rl_en = qm_info->pf_rl_en;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2624 params.pf_wfq_en = qm_info->pf_wfq_en;
1a5a5e8c1f7312 Michal Kalderon 2020-01-22 2625 params.global_rl_en = qm_info->vport_rl_en;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2626 params.vport_wfq_en = qm_info->vport_wfq_en;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2627 params.port_params = qm_info->qm_port_params;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2628
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2629 qed_qm_common_rt_init(p_hwfn, &params);
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2630
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2631 qed_cxt_hw_init_common(p_hwfn);
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2632
60afed72f51c74 Tomer Tayar 2017-04-06 2633 qed_init_cache_line_size(p_hwfn, p_ptt);
60afed72f51c74 Tomer Tayar 2017-04-06 2634
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2635 rc = qed_init_run(p_hwfn, p_ptt, PHASE_ENGINE, ANY_PHASE_ID, hw_mode);
1a635e488ecf6f Yuval Mintz 2016-08-15 2636 if (rc)
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2637 return rc;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2638
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2639 qed_wr(p_hwfn, p_ptt, PSWRQ2_REG_L2P_VALIDATE_VFID, 0);
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2640 qed_wr(p_hwfn, p_ptt, PGLUE_B_REG_USE_CLIENTID_IN_TAG, 1);
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2641
dbb799c39717e7 Yuval Mintz 2016-06-03 2642 if (QED_IS_BB(p_hwfn->cdev)) {
dbb799c39717e7 Yuval Mintz 2016-06-03 2643 num_pfs = NUM_OF_ENG_PFS(p_hwfn->cdev);
dbb799c39717e7 Yuval Mintz 2016-06-03 2644 for (pf_id = 0; pf_id < num_pfs; pf_id++) {
dbb799c39717e7 Yuval Mintz 2016-06-03 2645 qed_fid_pretend(p_hwfn, p_ptt, pf_id);
dbb799c39717e7 Yuval Mintz 2016-06-03 2646 qed_wr(p_hwfn, p_ptt, PRS_REG_SEARCH_ROCE, 0x0);
dbb799c39717e7 Yuval Mintz 2016-06-03 2647 qed_wr(p_hwfn, p_ptt, PRS_REG_SEARCH_TCP, 0x0);
dbb799c39717e7 Yuval Mintz 2016-06-03 2648 }
dbb799c39717e7 Yuval Mintz 2016-06-03 2649 /* pretend to original PF */
dbb799c39717e7 Yuval Mintz 2016-06-03 2650 qed_fid_pretend(p_hwfn, p_ptt, p_hwfn->rel_pf_id);
dbb799c39717e7 Yuval Mintz 2016-06-03 2651 }
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2652
9c79ddaa0f962d Mintz, Yuval 2017-03-14 2653 max_num_vfs = QED_IS_AH(cdev) ? MAX_NUM_VFS_K2 : MAX_NUM_VFS_BB;
9c79ddaa0f962d Mintz, Yuval 2017-03-14 2654 for (vf_id = 0; vf_id < max_num_vfs; vf_id++) {
1408cc1fa48c54 Yuval Mintz 2016-05-11 2655 concrete_fid = qed_vfid_to_concrete(p_hwfn, vf_id);
1408cc1fa48c54 Yuval Mintz 2016-05-11 2656 qed_fid_pretend(p_hwfn, p_ptt, (u16) concrete_fid);
1408cc1fa48c54 Yuval Mintz 2016-05-11 2657 qed_wr(p_hwfn, p_ptt, CCFC_REG_STRONG_ENABLE_VF, 0x1);
05fafbfb3d77f4 Yuval Mintz 2016-08-19 2658 qed_wr(p_hwfn, p_ptt, CCFC_REG_WEAK_ENABLE_VF, 0x0);
05fafbfb3d77f4 Yuval Mintz 2016-08-19 2659 qed_wr(p_hwfn, p_ptt, TCFC_REG_STRONG_ENABLE_VF, 0x1);
05fafbfb3d77f4 Yuval Mintz 2016-08-19 2660 qed_wr(p_hwfn, p_ptt, TCFC_REG_WEAK_ENABLE_VF, 0x0);
1408cc1fa48c54 Yuval Mintz 2016-05-11 2661 }
1408cc1fa48c54 Yuval Mintz 2016-05-11 2662 /* pretend to original PF */
1408cc1fa48c54 Yuval Mintz 2016-05-11 2663 qed_fid_pretend(p_hwfn, p_ptt, p_hwfn->rel_pf_id);
1408cc1fa48c54 Yuval Mintz 2016-05-11 2664
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2665 return rc;
fe56b9e6a8d957 Yuval Mintz 2015-10-26 @2666 }
fe56b9e6a8d957 Yuval Mintz 2015-10-26 2667

:::::: The code at line 2666 was first introduced by commit
:::::: fe56b9e6a8d957d6a20729d626027f800c17a2da qed: Add module with basic common support

:::::: TO: Yuval Mintz <Yuval.Mintz@qlogic.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35258 bytes --]