Re: [PATCH net-next 01/14] qed: FW 8.42.2.0 Internal ram offsets modifications

Jakub Kicinski
2020-01-23T14:26:11Z

On Wed, 22 Jan 2020 16:02:06 +0000, Michal Kalderon wrote:
> > From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> > owner@vger.kernel.org> On Behalf Of Jakub Kicinski
> >
> > On Wed, 22 Jan 2020 17:26:14 +0200, Michal Kalderon wrote:
> > > IRO stands for internal RAM offsets. Updating the FW binary produces
> > > different iro offsets. This file contains the different values, and a
> > > new representation of the values.
> > >
> > > Signed-off-by: Ariel Elior <ariel.elior@marvell.com>
> > > Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
> >
> > If you have different offsets depending on FW build - where is the code that
> > checks the FW version is the one driver expects? At a quick glance you're not
> > bumping any numbers in this patch..
> The FW version is bumped in patch 0009-qed-FW-8.42.2.0-HSI-Changes.patch and the driver loads
> The FW binary according to this version.

Please make it so the driver is not broken between patch 1 and patch 9.