Re: [PATCH for-next 1/7] RDMA/bnxt_re: Refactor queue pair creation code

[Leon Romanovsky <leon@kernel.org>]

On Sat, Jan 25, 2020 at 10:33:41PM +0530, Devesh Sharma wrote:
> On Fri, Jan 24, 2020 at 4:53 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Fri, Jan 24, 2020 at 12:52:39AM -0500, Devesh Sharma wrote:
> > > Restructuring the bnxt_re_create_qp function. Listing below
> > > the major changes:
> > >  --Monolithic central part of create_qp where attributes are
> > >    initialized is now enclosed in one function and this new
> > >    function has few more sub-functions.
> > >  --Top level qp limit checking code moved to a function.
> > >  --GSI QP creation and GSI Shadow qp creation code is handled
> > >    in a sub function.
> > >
> > > Signed-off-by: Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>
> > > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> > > Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> > > ---
> > >  drivers/infiniband/hw/bnxt_re/bnxt_re.h  |  13 +-
> > >  drivers/infiniband/hw/bnxt_re/ib_verbs.c | 635 ++++++++++++++++++++-----------
> > >  drivers/infiniband/hw/bnxt_re/main.c     |   3 +-
> > >  3 files changed, 434 insertions(+), 217 deletions(-)
> > >
> >
> > Please remove dev_err/dev_dbg/dev_* prints from the driver code.
> Sure I can do that, are you suggesting to add one more patch in this series?
> I guess it should be okay to follow the hw/efa way to  have debug msgs still on.

It is ok to use ibdev_* prints, it is not ok to use dev_* prints.

Thanks

> >
> >
> > Thanks