From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 401CCC2D0DB for ; Sat, 25 Jan 2020 18:50:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D63820716 for ; Sat, 25 Jan 2020 18:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579978252; bh=FrP3Lg8qYlzk8jQ23wIdfLUibCeo50zRFrZ8A5yWh48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jzhvBF39Iw4NTiDbSI0PcYyRSA6JD3NkQ3E/wuxV/QRbOE4hTrSQ/khyr0GEhjTjC Ws4x97QInvgz3C6sOtBC+IKb2JryQ0fVHoqqYBwyF7aSbAm/ldT1o/orh0e2g+I1B3 JDg3f/qgoic7EgLFZX8Raj4/mF8aHJTDV2Zt0WHM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbgAYSuv (ORCPT ); Sat, 25 Jan 2020 13:50:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:43592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbgAYSuv (ORCPT ); Sat, 25 Jan 2020 13:50:51 -0500 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 424E3206F0; Sat, 25 Jan 2020 18:50:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579978250; bh=FrP3Lg8qYlzk8jQ23wIdfLUibCeo50zRFrZ8A5yWh48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XxNmGpd/RE8k2DpCywmnI7M75RcVHKJWJr0f5nAw9kEclZldDFqgb+hhQWhhDEMyd t79y+CVoUoIh1vIhlfhqiu/JENJUIZ6ArQbt3/fNS1HRZc+EmiyeLLga2xozI3ydXC HItTgLgjm9bBk5jgYMFObrjJGp9GdKJjGoUAddPc= Date: Sat, 25 Jan 2020 20:50:45 +0200 From: Leon Romanovsky To: Devesh Sharma Cc: linux-rdma , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH for-next 1/7] RDMA/bnxt_re: Refactor queue pair creation code Message-ID: <20200125185045.GB2993@unreal> References: <1579845165-18002-1-git-send-email-devesh.sharma@broadcom.com> <1579845165-18002-2-git-send-email-devesh.sharma@broadcom.com> <20200124112347.GA35595@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sat, Jan 25, 2020 at 10:33:41PM +0530, Devesh Sharma wrote: > On Fri, Jan 24, 2020 at 4:53 PM Leon Romanovsky wrote: > > > > On Fri, Jan 24, 2020 at 12:52:39AM -0500, Devesh Sharma wrote: > > > Restructuring the bnxt_re_create_qp function. Listing below > > > the major changes: > > > --Monolithic central part of create_qp where attributes are > > > initialized is now enclosed in one function and this new > > > function has few more sub-functions. > > > --Top level qp limit checking code moved to a function. > > > --GSI QP creation and GSI Shadow qp creation code is handled > > > in a sub function. > > > > > > Signed-off-by: Naresh Kumar PBS > > > Signed-off-by: Selvin Xavier > > > Signed-off-by: Devesh Sharma > > > --- > > > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 13 +- > > > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 635 ++++++++++++++++++++----------- > > > drivers/infiniband/hw/bnxt_re/main.c | 3 +- > > > 3 files changed, 434 insertions(+), 217 deletions(-) > > > > > > > Please remove dev_err/dev_dbg/dev_* prints from the driver code. > Sure I can do that, are you suggesting to add one more patch in this series? > I guess it should be okay to follow the hw/efa way to have debug msgs still on. It is ok to use ibdev_* prints, it is not ok to use dev_* prints. Thanks > > > > > > Thanks