From: Jason Gunthorpe <jgg@ziepe.ca>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: Parav Pandit <parav@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH v6] libibverbs: display gid type in ibv_devinfo
Date: Wed, 5 Feb 2020 15:07:01 -0400 [thread overview]
Message-ID: <20200205190701.GD28298@ziepe.ca> (raw)
In-Reply-To: <CANjDDBhY5EkJpk-_yv1gM76ZidLk92WHokq2nZFAUqOUH_Q-CA@mail.gmail.com>
On Tue, Feb 04, 2020 at 08:56:54PM +0530, Devesh Sharma wrote:
> On Tue, Feb 4, 2020 at 8:01 PM Parav Pandit <parav@mellanox.com> wrote:
> >
> > Hi Devesh,
> >
> > > From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> > > owner@vger.kernel.org> On Behalf Of Devesh Sharma
> > > phys_state: LINK_UP (5)
> > > GID[ 0]: fe80:0000:0000:0000:b226:28ff:fed3:b0f0, IB/RoCE v1
> > > GID[ 1]: fe80:0000:0000:0000:b226:28ff:fed3:b0f0, RoCE v2
> > > GID[ 1]: fe80::b226:28ff:fed3:b0f0
> > Showing two entries as individual raw like this is surely confusing to user.
> > Either all content should be in single raw or as Leon said just single different format for RoCEv2 is fine.
> Yes, I liked the single display in new format, I would wait for Jason
> to agree/disagree and then send a rev.
Well, I wasn't thinking to display the GID[xx] prefix for the 2nd
entry
It seems like other people want to just show one, that seems OK too
Jason
next prev parent reply other threads:[~2020-02-05 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 9:47 [PATCH v6] libibverbs: display gid type in ibv_devinfo Devesh Sharma
2020-02-04 13:08 ` Leon Romanovsky
2020-02-04 14:31 ` Parav Pandit
2020-02-04 15:26 ` Devesh Sharma
2020-02-05 19:07 ` Jason Gunthorpe [this message]
2020-02-06 5:29 ` Devesh Sharma
2020-02-04 15:41 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205190701.GD28298@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=devesh.sharma@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox