From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7654C35247 for ; Wed, 5 Feb 2020 19:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7C9720730 for ; Wed, 5 Feb 2020 19:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="pQF+jp4G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727165AbgBETMa (ORCPT ); Wed, 5 Feb 2020 14:12:30 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37133 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbgBETMa (ORCPT ); Wed, 5 Feb 2020 14:12:30 -0500 Received: by mail-qt1-f193.google.com with SMTP id w47so2457601qtk.4 for ; Wed, 05 Feb 2020 11:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cHhpk8NxV7d9pWKZlCF5nt9V3XPrMbQR877f6pYAsUA=; b=pQF+jp4GGDjiysmwhQ+Xkq0b89TwGzXKgzgxCQw6lKOdhwudhgPb4nGl7JFIz7Fjv9 5n1NUkDdfLuxSGhaEF10mVCm+XfSoDSp7XCNTJSJ7iGJMWavq4ueZEpvKDNb0TbuEGvc 8nCDN+mHPBhCBjMnUZev5/EQc39CgdgEao6kr6J75jpFpvcnENUPMxtsssa6LbMxZxCw W+SkudsVJQ79Wihm+iNQQ7xy1dMt5iL7vc2QtLthDb/8YAZlAAvFvA5n/oJwtjoKPWb3 rh8z47PUB1sR+c3hN11CPgQVd0JkGrRMhIyXoYp37Grc0h+bNsl4Pc3s8r6LktTf45Xo GKTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cHhpk8NxV7d9pWKZlCF5nt9V3XPrMbQR877f6pYAsUA=; b=jXlpxPtorldbRwZ0xd1qcdrmobtsNwCAW+RrKfEmqA5iZQTz1tGMicewXPN85l1O8H splRLSAw9jVhUBsdX6rvuiEbTOCcVy47JBehPdKc+MWGCy/UTeRsYMJD6PjB3MPIJC/U vj7jIPMkfahHbQj4M5FHfwxlyJeEveJHdIUOb5WeBVKP/uWZaRs3oh8sOvlS/7XZszcT V0w9/9x1nHjaPqm982c+9Y5WBZrGVoBOrY5GZaPi0lYqF0P/BbGSrBsQfNMpKBvWEC70 h7oiTMxUSuNtfgc+axo44WOJfTiFiMhg6PDPJE03sJ/PJGo4MF1WobTASDzpHayHDdCJ Gh0w== X-Gm-Message-State: APjAAAUjG8NC2lRZQqdB71+LKOT/8l/UhbGziwTrl2ZzI2SLP7V88eqd JiZBkU1ZPjjrr403l7FrVnKuPA== X-Google-Smtp-Source: APXvYqwwkjuClHP/H3N912iMON9KM/kGpEONJBJM6R0lHU16ZT2buHb0aH2OSYhoxOYRu28GNgZyZA== X-Received: by 2002:ac8:78c:: with SMTP id l12mr34844777qth.187.1580929948837; Wed, 05 Feb 2020 11:12:28 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id n4sm353611qti.55.2020.02.05.11.12.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Feb 2020 11:12:28 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1izQ67-0004YH-OU; Wed, 05 Feb 2020 15:12:27 -0400 Date: Wed, 5 Feb 2020 15:12:27 -0400 From: Jason Gunthorpe To: "Goldman, Adam" Cc: linux-rdma@vger.kernel.org, mike.marciniszyn@intel.com, dennis.dalessandro@intel.com Subject: Re: [PATCH] kernel-boot: Do not perform device rename on OPA devices Message-ID: <20200205191227.GE28298@ziepe.ca> References: <1580824520-38122-1-git-send-email-adam.goldman@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1580824520-38122-1-git-send-email-adam.goldman@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Feb 04, 2020 at 08:55:20AM -0500, Goldman, Adam wrote: > From: "Goldman, Adam" > > PSM2 will not run with recent rdma-core releases. Several tools and > libraries like PSM2, require the hfi1 name to be present. > > Recent rdma-core releases added a new feature to rename kernel devices, > but the default configuration will not work with hfi1 fabrics. > > Related opa-psm2 github issue: > https://github.com/intel/opa-psm2/issues/43 > > Fixes: 5b4099d47be3 ("kernel-boot: Perform device rename to make stable names") > Reviewed-by: Mike Marciniszyn > Signed-off-by: Goldman, Adam > kernel-boot/rdma-persistent-naming.rules | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel-boot/rdma-persistent-naming.rules b/kernel-boot/rdma-persistent-naming.rules > index 9b61e16..95d6851 100644 > +++ b/kernel-boot/rdma-persistent-naming.rules > @@ -25,4 +25,4 @@ > # Device type = RoCE > # mlx5_0 -> rocex525400c0fe123455 > # > -ACTION=="add", SUBSYSTEM=="infiniband", PROGRAM="rdma_rename %k NAME_FALLBACK" > +ACTION=="add", SUBSYSTEM=="infiniband", KERNEL!="hfi1*", PROGRAM="rdma_rename %k NAME_FALLBACK" We are moving to the new names by default slowly, when wrong assumptions are found in other packages they need to be updated and their fixes pushed out. At some point the major distros will default this to On. People using leading edge distros can turn it off with the global switch Leon mentioned. This is the same process netdev went through when they introduced persistent names. If I recall, hfi was one of the reason this work was done. HFI has problems generating consistent names for its multi-function devices in various cases and I NAK'd the kernel hack to try and 'fix' that. Jason