From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49C30C34026 for ; Tue, 18 Feb 2020 16:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1691622B48 for ; Tue, 18 Feb 2020 16:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582043728; bh=OpTededsgD6bYLVvlW4VOYwh0qzYKHyB7ZByWjL9SBc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OBFE6e4JKCQb6o0HJQ/dp6edeHhHG3Gep3eDkjYj54Qc22lxcyBZSMt8JWmD9Te0m 6vIe6EvPsX+iYDyIzWXx1NIrbV08K7D3BmlZqe0ORDo64ZwYlwyn0IPA22pKQXJBiX F1OaeotcioaUQSOxYUCDgKUTJtGDKrYXMLLwYTFY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbgBRQf1 (ORCPT ); Tue, 18 Feb 2020 11:35:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:58224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbgBRQf1 (ORCPT ); Tue, 18 Feb 2020 11:35:27 -0500 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D53B42067D; Tue, 18 Feb 2020 16:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582043726; bh=OpTededsgD6bYLVvlW4VOYwh0qzYKHyB7ZByWjL9SBc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZaYoDUC0DPiltq1WOO3/zYuwe9RFjRfGPMlEYMOhFowVVKDRJ6Hn6KqZTIfyQVx2n V1/jPHm6kbX0Rixonv3GRG9IaUbMddsf2HZuTF6Bz3pxNZSjeWvWulPSPHeGKDHyvE 98yEjcTC/qpOoKnQlwtKA98uOAl4+10m3sWVRfaY= Date: Tue, 18 Feb 2020 18:35:22 +0200 From: Leon Romanovsky To: "Gustavo A. R. Silva" Cc: Boris Pismenny , Saeed Mahameed , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net/mlx5: IPsec, Replace zero-length array with flexible-array member Message-ID: <20200218163522.GB11536@unreal> References: <20200217195434.GA1166@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217195434.GA1166@embeddedor> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Feb 17, 2020 at 01:54:34PM -0600, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct foo { > int stuff; > struct boo array[]; > }; > > By making use of the mechanism above, we will get a compiler warning > in case the flexible array does not occur last in the structure, which > will help us prevent some kind of undefined behavior bugs from being > inadvertently introduced[3] to the codebase from now on. > > Also, notice that, dynamic memory allocations won't be affected by > this change: > > "Flexible array members have incomplete type, and so the sizeof operator > may not be applied. As a quirk of the original implementation of > zero-length arrays, sizeof evaluates to zero."[1] > > This issue was found with the help of Coccinelle. > > [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > [2] https://github.com/KSPP/linux/issues/21 > [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Can you please do one patch for whole mlx5, instead of many identical patches? Thanks