linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Honggang LI <honli@redhat.com>,
	Gal Pressman <galpress@amazon.com>
Subject: Re: RDMA device renames and node description
Date: Wed, 19 Feb 2020 12:58:00 -0400	[thread overview]
Message-ID: <20200219165800.GS31668@ziepe.ca> (raw)
In-Reply-To: <bea50739-918b-ae6f-5fac-f5642c56f1da@intel.com>

On Wed, Feb 19, 2020 at 09:14:06AM -0500, Dennis Dalessandro wrote:

> > ABI breakage is a strong word, luckily enough it is not defined at all.
> > We never considered dmesg prints, device names, device ordering as an
> > ABI. You can't rely on debug features too, they can disappear too.
> 
> Agree, it is a strong word and we can call it what you want. The point is
> you should be able to rely on the node description not being changed out
> from under you unnecessarily though. We aren't talking about a debug feature
> here but a core feature to real world deployments.

People really use the node description as some stable name? And then
they put the HCA name in it? Why?

Is that some thing unique to the OPA subnet manager?

I don't recall people complaining about this when we introduced
rdma-ndd by default and changed all the node descriptions away from
the kernel default.

Also don't forget the whole thing about the node description is
inherently racey, so relying on it is Rather A Bad Idea.

Should we change the default format string of rdma-ndd to something
else?

Jason

  parent reply	other threads:[~2020-02-19 16:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 18:13 RDMA device renames and node description Dennis Dalessandro
2020-02-18 14:04 ` Leon Romanovsky
2020-02-18 17:11   ` Dennis Dalessandro
2020-02-18 20:08     ` Jason Gunthorpe
2020-02-19  7:11     ` Leon Romanovsky
2020-02-19 14:14       ` Dennis Dalessandro
2020-02-19 14:35         ` Gal Pressman
2020-02-19 15:10           ` Leon Romanovsky
2020-02-19 16:54           ` Jason Gunthorpe
2020-02-19 14:48         ` Leon Romanovsky
2020-02-19 15:34           ` Dennis Dalessandro
2020-02-19 16:58         ` Jason Gunthorpe [this message]
2020-02-19 19:35           ` Dennis Dalessandro
2020-02-19 23:18             ` Ira Weiny
2020-02-20  2:26               ` Dennis Dalessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219165800.GS31668@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dennis.dalessandro@intel.com \
    --cc=galpress@amazon.com \
    --cc=honli@redhat.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).