From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
Aya Levin <ayal@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/mlx5e: Fix error code in mlx5e_fec_in_caps()
Date: Mon, 24 Feb 2020 12:52:33 +0200 [thread overview]
Message-ID: <20200224105233.GB468372@unreal> (raw)
In-Reply-To: <20200224065557.d23b4yd46kjnzfya@kili.mountain>
On Mon, Feb 24, 2020 at 09:55:57AM +0300, Dan Carpenter wrote:
> The mlx5e_fec_in_caps() function is type bool so these negative returns
> become "return true;" when they should be "return false;"
>
> Fixes: 2132b71f78d2 ("net/mlx5e: Advertise globaly supported FEC modes")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/port.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
prev parent reply other threads:[~2020-02-24 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 6:55 [PATCH] net/mlx5e: Fix error code in mlx5e_fec_in_caps() Dan Carpenter
2020-02-24 10:52 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224105233.GB468372@unreal \
--to=leon@kernel.org \
--cc=ayal@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=eranbe@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).