From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=0s84=4M=vger.kernel.org=linux-rdma-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CFADDC3567B
	for <linux-rdma@archiver.kernel.org>; Mon, 24 Feb 2020 10:52:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id A422D20836
	for <linux-rdma@archiver.kernel.org>; Mon, 24 Feb 2020 10:52:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1582541557;
	bh=pRbIAs5C//mo9jzQh7oINEMAkmc7NcM4HYwn4lFZ03Q=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=HB3o+IugNG9xMd4mLqj7NpBBFv6Cugu6hqVkAp6FhmDV8M/8gWNEJ1PcTC7sQuKlb
	 DKiiesF3O6jFfTJxpTtdG4JyLxQkndw13T+heY8S+ebQG82jegkWgUgMHEVGYIp41u
	 QVtRnRHTTo4pMEunf7suVF9H5qyxG9d+1h11MtcY=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727185AbgBXKwh (ORCPT <rfc822;linux-rdma@archiver.kernel.org>);
        Mon, 24 Feb 2020 05:52:37 -0500
Received: from mail.kernel.org ([198.145.29.99]:41288 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726765AbgBXKwg (ORCPT <rfc822;linux-rdma@vger.kernel.org>);
        Mon, 24 Feb 2020 05:52:36 -0500
Received: from localhost (unknown [213.57.247.131])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id B584B2080D;
        Mon, 24 Feb 2020 10:52:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1582541556;
        bh=pRbIAs5C//mo9jzQh7oINEMAkmc7NcM4HYwn4lFZ03Q=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=w5djC6IpGiXEDU+/rrZLeL8VSFFZ7ZV67y6j2TAGhG0fOzNMcCRZC2PrGf816761s
         phE+DT9ZjU5BSiqHo0DTpl0SShDWadkbAic3qrtX5+d9LJYFqNqYz8ZraDCVEbxrqg
         tA24caTLG9AThDJcjzJD5heE4q+xLqoDdeVlS99A=
Date:   Mon, 24 Feb 2020 12:52:33 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Saeed Mahameed <saeedm@mellanox.com>,
        Aya Levin <ayal@mellanox.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/mlx5e: Fix error code in mlx5e_fec_in_caps()
Message-ID: <20200224105233.GB468372@unreal>
References: <20200224065557.d23b4yd46kjnzfya@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200224065557.d23b4yd46kjnzfya@kili.mountain>
Sender: linux-rdma-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-rdma.vger.kernel.org>
X-Mailing-List: linux-rdma@vger.kernel.org

On Mon, Feb 24, 2020 at 09:55:57AM +0300, Dan Carpenter wrote:
> The mlx5e_fec_in_caps() function is type bool so these negative returns
> become "return true;" when they should be "return false;"
>
> Fixes: 2132b71f78d2 ("net/mlx5e: Advertise globaly supported FEC modes")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/port.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>