From: Jason Gunthorpe <jgg@ziepe.ca>
To: Alexander Lobakin <alobakin@dlink.ru>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Maxim Mikityanskiy <maximmi@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma] IB/mlx5: Optimize u64 division on 32-bit arches
Date: Wed, 4 Mar 2020 13:19:25 -0400 [thread overview]
Message-ID: <20200304171925.GA7515@ziepe.ca> (raw)
In-Reply-To: <20200217073629.8051-1-alobakin@dlink.ru>
On Mon, Feb 17, 2020 at 10:36:29AM +0300, Alexander Lobakin wrote:
> Commit f164be8c0366 ("IB/mlx5: Extend caps stage to handle VAR
> capabilities") introduced a straight "/" division of the u64
> variable "bar_size".
> This was fixed with commit 685eff513183 ("IB/mlx5: Use div64_u64
> for num_var_hw_entries calculation"). However, div64_u64() is
> redundant here as mlx5_var_table::stride_size is of type u32.
> Make the actual code way more optimized on 32-bit kernels using
> div_u64() and fix 80 chars break-through by the way.
>
> Fixes: 685eff513183 ("IB/mlx5: Use div64_u64 for num_var_hw_entries
> calculation")
> Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
> ---
> drivers/infiniband/hw/mlx5/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-03-04 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 7:36 [PATCH rdma] IB/mlx5: Optimize u64 division on 32-bit arches Alexander Lobakin
2020-03-04 17:19 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304171925.GA7515@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alobakin@dlink.ru \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maximmi@mellanox.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).