From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32035C1975A for ; Tue, 17 Mar 2020 18:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F01C220752 for ; Tue, 17 Mar 2020 18:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="q9fgMX8W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbgCQSKo (ORCPT ); Tue, 17 Mar 2020 14:10:44 -0400 Received: from mail-am6eur05on2044.outbound.protection.outlook.com ([40.107.22.44]:6026 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726476AbgCQSKo (ORCPT ); Tue, 17 Mar 2020 14:10:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KuCgyByGySZKMtKOjjHZ6hE1sb5nMv96K1uF5uU3SbesziywT82/V5Eq610mnNkVyw8Af0Fie0wGDgcqB7CZp+mQx91bKjI99K6AkWDkbWbAEOoKRqZIAz+2CKFGntIiX9ONrSqrhPxPSzON0MUBX/ta5WOr96u5x7tk8ftw5ZGfURlrPfRWODCxlNW3b2IofYpWgd4WP9JFaC0z76CdviZ0Qc42q6OaQxfTv4FLaC5KGrfZE5qWqMBDX9iGbf6I0OEUY42AtgHZ9esKrCvhl5aMVHnPEcwnw1aHtORpOXA2bSxTlim/iUL8IjddDP3PaeLeEWvT5OJbKL8/LjjD5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ghq074pjdmHC6oixQevInihWIDb0OlwNz3X0RDphByo=; b=AMXUcnE9sMM6p9BHFbE4yMM6ukRRmhk4Uedyd0M0sPMVN7eujA7qkz9R4ZbR6wbMYJXbEsTL7S4S/qJMUn5VYjYY7ubO1tcg/f3fLiG/CsD4CE8dy68b+SgIYcQnLrB152FcBl81mFJOxB4oNUoCBauB2uJ4g+scWuk551Gf9wQEcT2YWzyVlW7YuAcHWNUgeS7+u496nOuyavINM85+OpUEqyvHCiuJg+FkLe6C3+7YTY1sZ59ohfIF3mWYPlPs1UTSSBqEGOXbxR2ApldfXPLGT+4QTzyHbmLXoAXvfK+udrha6jcDjW2Zu7e/iDTkgXK2fmfv4y+rf2cW1XjYrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ghq074pjdmHC6oixQevInihWIDb0OlwNz3X0RDphByo=; b=q9fgMX8WtWdKxeFGA9XKHJzd5ZNpLlcKER3+WZ4IdR2wki6qAJkM2G+mZ5JT4TJpGi7oShxVib+774FsfPl/p/9QDKW+33Uw/ZEyU2QkGhX6jSj5AhMid3vpO/UDiv0ALjJCk28swjND/WU6n5z4bgX5CVn3l+rxW0RxdeA+DjI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (52.133.14.15) by VI1PR05MB6589.eurprd05.prod.outlook.com (20.179.25.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18; Tue, 17 Mar 2020 18:10:40 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::18d2:a9ea:519:add3]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::18d2:a9ea:519:add3%7]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 18:10:39 +0000 Date: Tue, 17 Mar 2020 15:10:36 -0300 From: Jason Gunthorpe To: Max Gurtovoy Cc: Leon Romanovsky , linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, loberman@redhat.com, bvanassche@acm.org, linux-rdma@vger.kernel.org, kbusch@kernel.org, dledford@redhat.com, idanb@mellanox.com, shlomin@mellanox.com, oren@mellanox.com, vladimirk@mellanox.com Subject: Re: [PATCH 1/5] IB/core: add a simple SRQ set per PD Message-ID: <20200317181036.GX13183@mellanox.com> References: <20200317134030.152833-1-maxg@mellanox.com> <20200317134030.152833-2-maxg@mellanox.com> <20200317135518.GG3351@unreal> <46bb23ed-2941-2eaa-511a-3d0f3b09a9ed@mellanox.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46bb23ed-2941-2eaa-511a-3d0f3b09a9ed@mellanox.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MN2PR14CA0026.namprd14.prod.outlook.com (2603:10b6:208:23e::31) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:44::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (142.68.57.212) by MN2PR14CA0026.namprd14.prod.outlook.com (2603:10b6:208:23e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.16 via Frontend Transport; Tue, 17 Mar 2020 18:10:39 +0000 Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jEGfk-0007Km-8V; Tue, 17 Mar 2020 15:10:36 -0300 X-Originating-IP: [142.68.57.212] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 341e701e-e82f-4685-b29c-08d7ca9e7ff3 X-MS-TrafficTypeDiagnostic: VI1PR05MB6589:|VI1PR05MB6589: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(39860400002)(346002)(136003)(396003)(199004)(37006003)(33656002)(478600001)(2906002)(86362001)(81166006)(4744005)(9746002)(9786002)(8676002)(5660300002)(316002)(186003)(81156014)(26005)(8936002)(52116002)(4326008)(6862004)(6636002)(107886003)(66556008)(36756003)(1076003)(66946007)(2616005)(66476007)(24400500001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB6589;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4rE3t22D/5W6sy9ktaqk8nI8paF9HJuMDsAzM/r4pW1FsAPRLb4erYOp0J1ZWgN5DfgJoeacJ/Tt7nk5vKSsWdeoVcxMZn42JJZSe+R4zwq9NRa0wfXHErmzAl9EPjDzCFA7YYFECKwDwFz25zlSWAwiiRjWR+Bob4sJUULfL+JaF9biHzoroBdErrXUzO73FOhhsWaRnZmDsa2ZU37zn7sKKnn4vXoB+90VgOzthxnmGQEnJQjhYjrN1PIHwNaSklRYeaTrkW/mMkT7XLcM0tk98tqmvZ8GKmm+yW2+gPVJGeGD07jdAOTMc2KQnZtSS2cx1j02HxdkseWiy2GqR1vqUbuNHJMhPLX0HjMzPgSokntTBdmuTrUvufAhmRVfpC9jcMZPONKP97LoiKl4HFtRSe037g9xzO3M8Qwk847zRKETGCbBlOhHET17p9y8o/+qeemO3Ka70s//YBz6Aab2ydP4RXdLYVTg5Ni2KJpAxDytr4eH/aaXk0RNqIBp X-MS-Exchange-AntiSpam-MessageData: OZMAahtjmEzNU1mJaqBIukoEKRYxUfZ7Dpq4wxwfrIRZybW2jWGHQd/fChBJdiiUE/oJUkfH277yo3s/iqdtWCW3p+Dq0a7nYP5m71o/XM7JFwMliBQvn7pWrIeooAHHuSJpOyHpqvtm/xnQeOtBoQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 341e701e-e82f-4685-b29c-08d7ca9e7ff3 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 18:10:39.8124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zKGjPDVrufP/+tfxzehGNgwDCpLSvvP4elOnD5mm+oV3ShB42BLn6TjmKq2N8oHuCCuR+/J0b9A2NLTqcMIfdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6589 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Mar 17, 2020 at 06:37:57PM +0200, Max Gurtovoy wrote: > > > +#include > > > + > > > +struct ib_srq *rdma_srq_get(struct ib_pd *pd); > > > +void rdma_srq_put(struct ib_pd *pd, struct ib_srq *srq); > > At the end, it is not get/put semantics but more add/remove. > > srq = rdma_srq_add ? > > rdma_srq_remove(pd, srq) ? > > Doesn't seems right to me. > > Lets make it simple. For asking a SRQ from the PD set lets use rdma_srq_get > and returning to we'll use rdma_srq_put. Is there reference couting here? get/put should be restricted to refcounting APIs, IMHO. Jason