From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821D8C1975A for ; Tue, 17 Mar 2020 19:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51BE820714 for ; Tue, 17 Mar 2020 19:54:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="dINjBBrT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgCQTyY (ORCPT ); Tue, 17 Mar 2020 15:54:24 -0400 Received: from mail-eopbgr60043.outbound.protection.outlook.com ([40.107.6.43]:17822 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726294AbgCQTyY (ORCPT ); Tue, 17 Mar 2020 15:54:24 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bw/gAzwe4vgRkK+/1yf5KzeGVVtDDfK027c2X0tS0MvDKwQvBucVp1NOq2u4XrOyu4/a0BKpzSp3eaOkaECakJrtOM0hz2BBHwsFqARNvDtFQFLij0BkAjqAEYM7km4BcG8cStBXFxMU6MSJxwkPo2gzk9+Aw8ilOYQVkZ085wlJCjf5fzmyNGyLsxXm6kxEMHgukjx7ZNH8dsXUPcz4e06RfYlXZyK/j/raxYbpMNKMs8zyf4RkIj6bvxVGCToDDlTuG+22f282o0fhFIDqL2M+CusUlbzEKp1y2btfdoivIoyxIoktRUvgLPnHGeW5bdAjbRjIY6FWUmeJDv28FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mcfG8F5k1CWsKjuryRTKFitzLrtRq9s1b/GPSBMRFY=; b=UTHtuGVCCo0HkgdvQvNq/uU1GftZGAx1yxVikWnLU1ncSDc3L+o2l15xDz6+XR3wxHLUYTr9M3w/iiaNkjDnE22bOGUReo2iS+RxD86jddu/cjSa7uXCgG9B3mQ816OJr+2LEDpsBj1OCFv5VNbTXlgJDJ7JwLbkM+WXRCyKIZCPY2Dh3AqhgEQVf76leDFJPa6Xs4cjRw00gXkPBCsUptEeYdWRcGH0pNSNO0ZN7gjW9amJW3ZS5fBZ8BaHbClIff780XsbSIV0NUXDjZc5YeADSVCmZV82f86DSmH5tXtIBPEkhTsvs4WH8WCjGBXHm9UAFtMcpCxiRxZtp2UHrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mcfG8F5k1CWsKjuryRTKFitzLrtRq9s1b/GPSBMRFY=; b=dINjBBrTnT/QhOvXZnzMT/KFuXQXRccBsEQbMkG9R1pa9ghW5lnlGhOFFPzqavcjughxwqFRBVXPnFRuWwSj1JgArtTbBtYGaSFpiEqA5HdlYkyWdgVHVjAprlUyN5xol9M0zzKzZ9rw4IObJBrHUsDuxPzelt7JriQaM8/bxWc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Received: from AM6PR05MB6408.eurprd05.prod.outlook.com (20.179.5.215) by AM6PR05MB6149.eurprd05.prod.outlook.com (20.178.94.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.19; Tue, 17 Mar 2020 19:54:21 +0000 Received: from AM6PR05MB6408.eurprd05.prod.outlook.com ([fe80::c99f:9130:561f:dea0]) by AM6PR05MB6408.eurprd05.prod.outlook.com ([fe80::c99f:9130:561f:dea0%3]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 19:54:21 +0000 Date: Tue, 17 Mar 2020 21:54:17 +0200 From: Leon Romanovsky To: Jason Gunthorpe Cc: Max Gurtovoy , linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, loberman@redhat.com, bvanassche@acm.org, linux-rdma@vger.kernel.org, kbusch@kernel.org, dledford@redhat.com, idanb@mellanox.com, shlomin@mellanox.com, oren@mellanox.com, vladimirk@mellanox.com Subject: Re: [PATCH 1/5] IB/core: add a simple SRQ set per PD Message-ID: <20200317195417.GK3351@unreal> References: <20200317134030.152833-1-maxg@mellanox.com> <20200317134030.152833-2-maxg@mellanox.com> <20200317135518.GG3351@unreal> <46bb23ed-2941-2eaa-511a-3d0f3b09a9ed@mellanox.com> <20200317181036.GX13183@mellanox.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317181036.GX13183@mellanox.com> X-ClientProxiedBy: ZR0P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::22) To AM6PR05MB6408.eurprd05.prod.outlook.com (2603:10a6:20b:b8::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (2a00:a040:183:2d::393) by ZR0P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18 via Frontend Transport; Tue, 17 Mar 2020 19:54:21 +0000 X-Originating-IP: [2a00:a040:183:2d::393] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: eddd1e65-7681-43be-0aa5-08d7caacfc68 X-MS-TrafficTypeDiagnostic: AM6PR05MB6149:|AM6PR05MB6149: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(346002)(366004)(396003)(376002)(136003)(39860400002)(199004)(33716001)(33656002)(86362001)(2906002)(66946007)(66476007)(66556008)(5660300002)(478600001)(186003)(8936002)(16526019)(6862004)(6666004)(4326008)(107886003)(9686003)(4744005)(52116002)(6486002)(316002)(1076003)(6496006)(8676002)(81166006)(6636002)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB6149;H:AM6PR05MB6408.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 08o+tNZrY8FeZ9eYKRgy3evY0bMd2kyIt4GUBaO685VbAtP93AEbkppklMH/7cYla2JjN8p2B8yzl92MUtOp4CrShJHvHWAkbZhPRMFLoymQIj3UcjGzMFT1iUxftO35XbXB2wCTtX/V2lY0yTxDkGTouWJs92zNzkhPHE57Yf0E696kImwk6coZ219fkoTZ4XvUeRXVFXIhD2c76OSyh0MgbNhYfWa/rEo2xVbEDVhIZb9fgXL1gHzcA+EXhiuwVZHtjD1xQRTtIh89pRPk5yEe/CPMQFcu9hkVJHYZNkb+1IH5mbZo1sBc5ivhK7YM0mPHIL6vdD5Nu8+IycdhC/UKSNKSQUKabDchbpnEIyMbkJFB7Dpl+Tj8/IOQmidRmLWN5w75dn6DgR5jhctSnfkY9LfvNRa6h5PyG1xdDqCkGtZTdp6tVdUQ6MYa8Pzo X-MS-Exchange-AntiSpam-MessageData: fTlqLD1qMjpqlO0KmCIcpfT4+HxA/09CWoHk1Blioe1UngBEKbzT+DjJR0TS6NW83pWlPqacqtCc9j9x7ZoOkKCebwxfJTfPXMKyc/z3gpJ7jZEgmrPcEH5xEs5fgEpGrVIegmbFn0tCS5Am7PtH3xLAFn52sWl1ZYiH4PkT9Ak= X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eddd1e65-7681-43be-0aa5-08d7caacfc68 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 19:54:21.6295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BbtTwdKcvJDrkay57bY+FqYSV4GIYpyQZ5yCLstCY20P6irFuZMARkt56seu5enx6H+LYO9WXJQHI7uOjP0n2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6149 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Mar 17, 2020 at 03:10:36PM -0300, Jason Gunthorpe wrote: > On Tue, Mar 17, 2020 at 06:37:57PM +0200, Max Gurtovoy wrote: > > > > > +#include > > > > + > > > > +struct ib_srq *rdma_srq_get(struct ib_pd *pd); > > > > +void rdma_srq_put(struct ib_pd *pd, struct ib_srq *srq); > > > At the end, it is not get/put semantics but more add/remove. > > > > srq = rdma_srq_add ? > > > > rdma_srq_remove(pd, srq) ? > > > > Doesn't seems right to me. > > > > Lets make it simple. For asking a SRQ from the PD set lets use rdma_srq_get > > and returning to we'll use rdma_srq_put. > > Is there reference couting here? get/put should be restricted to > refcounting APIs, IMHO. No, there is no refcounting, Max introduced some counter which he decrease and increase, but doesn't have any other usage of it, simply burning CPU cycles. Thanks > > Jason