From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F1EC4332D for ; Fri, 20 Mar 2020 14:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D2CE2070A for ; Fri, 20 Mar 2020 14:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584714582; bh=iO6PRguOPpdhSYfKfnRIXG/xdZNHL9pJgUVBEC5X2QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oNhdr0ZOdOwTIou531z3w8X7A0z2NLJt5h1mEDKUBkqxOBs8N2B1/cyO4/3q47VoL JoXqoO6JFcbERKhcDDVi6/tE4iUFI31VMdLcFROoNH/MmtdrZgu/d5P7EdQKTj9HoT ykKnRmTtfnhMDmpvbSgoHPwWaOXMTokUVYR2wLyQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727278AbgCTO3m (ORCPT ); Fri, 20 Mar 2020 10:29:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:53506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727152AbgCTO3m (ORCPT ); Fri, 20 Mar 2020 10:29:42 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C76F920709; Fri, 20 Mar 2020 14:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584714581; bh=iO6PRguOPpdhSYfKfnRIXG/xdZNHL9pJgUVBEC5X2QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fq8vVPPByb8BGeX77YGZoVhjCrMm1QMv+o0votFlm1aF/5TW/1PkZWItcpF8/K8gp /f2xIajzPJSVD7DpoECohlot2BE6yqlR8UfgBu9FYpcLJxlqE7FwTBTvJKwjr6MMym RAFOA/2qqfu/HOqTwNk9Ws956y04iw15/wH1jYlQ= Date: Fri, 20 Mar 2020 16:29:31 +0200 From: Leon Romanovsky To: Dan Carpenter Cc: Yishai Hadas , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] IB/mlx5: Fix a NULL vs IS_ERR() check Message-ID: <20200320142931.GF514123@unreal> References: <20200320132641.GF95012@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320132641.GF95012@mwanda> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Mar 20, 2020 at 04:26:41PM +0300, Dan Carpenter wrote: > The kzalloc() function returns NULL, not error pointers. > > Fixes: 30f2fe40c72b ("IB/mlx5: Introduce UAPIs to manage packet pacing") > Signed-off-by: Dan Carpenter > --- > drivers/infiniband/hw/mlx5/qos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Of course, thanks a lot. Acked-by: Leon Romanovsky