* [PATCH v2][next] RDMA/hns: Fix uninitialized variable bug
@ 2020-03-28 2:35 Gustavo A. R. Silva
2020-03-28 3:02 ` liweihang
2020-03-29 14:10 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-03-28 2:35 UTC (permalink / raw)
To: Lijun Ou, Wei Hu(Xavier), Weihang Li, Doug Ledford,
Jason Gunthorpe, Xi Wang
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva
There is a potential execution path in which variable *ret* is returned
without being properly initialized, previously.
Fix this by initializing variable *ret* to 0.
Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")
Fixes: 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
- Set ret to 0 instead of -ENODEV. Thanks Weihang Li, for the feedback.
drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hem.c b/drivers/infiniband/hw/hns/hns_roce_hem.c
index c96378718f88..263338b90d7a 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hem.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hem.c
@@ -603,7 +603,7 @@ static int set_mhop_hem(struct hns_roce_dev *hr_dev,
{
struct ib_device *ibdev = &hr_dev->ib_dev;
int step_idx;
- int ret;
+ int ret = 0;
if (index->inited & HEM_INDEX_L0) {
ret = hr_dev->hw->set_hem(hr_dev, table, obj, 0);
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2][next] RDMA/hns: Fix uninitialized variable bug
2020-03-28 2:35 [PATCH v2][next] RDMA/hns: Fix uninitialized variable bug Gustavo A. R. Silva
@ 2020-03-28 3:02 ` liweihang
2020-03-29 14:10 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: liweihang @ 2020-03-28 3:02 UTC (permalink / raw)
To: Gustavo A. R. Silva, oulijun, Huwei (Xavier), Doug Ledford,
Jason Gunthorpe, wangxi (M)
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
On 2020/3/28 10:32, Gustavo A. R. Silva wrote:
> There is a potential execution path in which variable *ret* is returned
> without being properly initialized, previously.
>
> Fix this by initializing variable *ret* to 0.
>
> Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")
> Fixes: 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Set ret to 0 instead of -ENODEV. Thanks Weihang Li, for the feedback.
>
> drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hem.c b/drivers/infiniband/hw/hns/hns_roce_hem.c
> index c96378718f88..263338b90d7a 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hem.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hem.c
> @@ -603,7 +603,7 @@ static int set_mhop_hem(struct hns_roce_dev *hr_dev,
> {
> struct ib_device *ibdev = &hr_dev->ib_dev;
> int step_idx;
> - int ret;
> + int ret = 0;
>
> if (index->inited & HEM_INDEX_L0) {
> ret = hr_dev->hw->set_hem(hr_dev, table, obj, 0);
>
Acked-by: Weihang Li <liweihang@huawei.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2][next] RDMA/hns: Fix uninitialized variable bug
2020-03-28 2:35 [PATCH v2][next] RDMA/hns: Fix uninitialized variable bug Gustavo A. R. Silva
2020-03-28 3:02 ` liweihang
@ 2020-03-29 14:10 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-03-29 14:10 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Lijun Ou, Wei Hu(Xavier), Weihang Li, Doug Ledford, Xi Wang,
linux-rdma, linux-kernel
On Fri, Mar 27, 2020 at 09:35:39PM -0500, Gustavo A. R. Silva wrote:
> There is a potential execution path in which variable *ret* is returned
> without being properly initialized, previously.
>
> Fix this by initializing variable *ret* to 0.
>
> Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")
> Fixes: 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Weihang Li <liweihang@huawei.com>
> ---
> Changes in v2:
> - Set ret to 0 instead of -ENODEV. Thanks Weihang Li, for the feedback.
>
> drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-29 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-28 2:35 [PATCH v2][next] RDMA/hns: Fix uninitialized variable bug Gustavo A. R. Silva
2020-03-28 3:02 ` liweihang
2020-03-29 14:10 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).